Nokogiri already in gemspec#150
Merged
Lordnibbler merged 2 commits intoSAML-Toolkits:masterfrom Sep 26, 2014
billyyarosh:fix-nokogiri-gemspec
Merged
Nokogiri already in gemspec#150Lordnibbler merged 2 commits intoSAML-Toolkits:masterfrom billyyarosh:fix-nokogiri-gemspec
Lordnibbler merged 2 commits intoSAML-Toolkits:masterfrom
billyyarosh:fix-nokogiri-gemspec
Conversation
Contributor
|
Your tests are erroring, can you please re-run? |
Contributor
Author
|
ruby 1.8 handles test group differently and will still need to depend on nokogiri being in the test group. Fixed and committed. |
Contributor
|
Thanks @keaplogik |
Lordnibbler
added a commit
that referenced
this pull request
Sep 26, 2014
Nokogiri already in gemspec
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't think you need nokogiri in the gemfile and gemspec. This has caused us some pain because it is test scoped.