Skip to content

Commit f123a7f

Browse files
Apply suggestions from code review
Co-authored-by: Aditya Sharad <6874315+adityasharad@users.noreply.github.com>
1 parent 69a4cac commit f123a7f

3 files changed

Lines changed: 3 additions & 3 deletions

File tree

extensions/ql-vscode/CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
- Query results with no string representation will now be displayed with placeholder text in query results. Previously, they were omitted. [#694](https://github.com/github/vscode-codeql/pull/694)
88
- Add a label for the language of a database in the databases view. This will only take effect for new databases created with the CodeQL CLI v2.4.1 or later. [#697](https://github.com/github/vscode-codeql/pull/697)
99
- Add clearer error message when running a query using a missing or invalid qlpack. [#702](https://github.com/github/vscode-codeql/pull/702)
10-
- Add clearer error message when trying to run command from the query history view and no item is history selected. [#702](https://github.com/github/vscode-codeql/pull/702)
10+
- Add clearer error message when trying to run a command from the query history view if no item in the history is selected. [#702](https://github.com/github/vscode-codeql/pull/702)
1111

1212
## 1.3.7 - 24 November 2020
1313

extensions/ql-vscode/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -304,7 +304,7 @@
304304
},
305305
{
306306
"command": "codeQLQueryHistory.openQuery",
307-
"title": "Open the Query that Produced these results",
307+
"title": "Open the query that produced these results",
308308
"icon": {
309309
"light": "media/light/edit.svg",
310310
"dark": "media/dark/edit.svg"

extensions/ql-vscode/src/run-queries.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -479,7 +479,7 @@ export async function compileAndRunQueryAgainstDatabase(
479479
const packConfig = await cliServer.resolveLibraryPath(diskWorkspaceFolders, queryPath);
480480

481481
if (!packConfig.dbscheme) {
482-
throw new Error('No dbscheme. Is your qlpack.yml missing or invalid?');
482+
throw new Error('Could not find a database scheme for this query. Please check that you have a valid qlpack.yml file for this query, which refers to a database scheme either in the `dbscheme` field or through one of its dependencies.');
483483
}
484484

485485
// Check whether the query has an entirely different schema from the

0 commit comments

Comments
 (0)