Skip to content

Commit e2b6817

Browse files
committed
Make "Save" button respect selected rows
1 parent 3bac7ca commit e2b6817

2 files changed

Lines changed: 21 additions & 9 deletions

File tree

extensions/ql-vscode/src/view/model-editor/LibraryRow.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -243,7 +243,7 @@ export const LibraryRow = ({
243243
<SectionDivider />
244244
<ButtonsContainer>
245245
<VSCodeButton onClick={handleSave} disabled={!hasUnsavedChanges}>
246-
Save
246+
{selectedSignatures.size === 0 ? "Save" : "Save selected"}
247247
</VSCodeButton>
248248
</ButtonsContainer>
249249
</>

extensions/ql-vscode/src/view/model-editor/ModelEditor.tsx

Lines changed: 20 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -215,15 +215,27 @@ export function ModelEditor({
215215
const onSaveAllClick = useCallback(() => {
216216
vscode.postMessage({
217217
t: "saveModeledMethods",
218+
methodSignatures:
219+
selectedSignatures.size === 0
220+
? undefined
221+
: Array.from(selectedSignatures),
218222
});
219-
}, []);
223+
}, [selectedSignatures]);
220224

221-
const onSaveModelClick = useCallback((methodSignatures: string[]) => {
222-
vscode.postMessage({
223-
t: "saveModeledMethods",
224-
methodSignatures,
225-
});
226-
}, []);
225+
const onSaveModelClick = useCallback(
226+
(methodSignatures: string[]) => {
227+
vscode.postMessage({
228+
t: "saveModeledMethods",
229+
methodSignatures:
230+
selectedSignatures.size === 0
231+
? methodSignatures
232+
: methodSignatures.filter((signature) =>
233+
selectedSignatures.has(signature),
234+
),
235+
});
236+
},
237+
[selectedSignatures],
238+
);
227239

228240
const onGenerateFromSourceClick = useCallback(() => {
229241
vscode.postMessage({
@@ -326,7 +338,7 @@ export function ModelEditor({
326338
onClick={onSaveAllClick}
327339
disabled={modifiedSignatures.size === 0}
328340
>
329-
Save all
341+
{selectedSignatures.size === 0 ? "Save all" : "Save selected"}
330342
</VSCodeButton>
331343
<VSCodeButton appearance="secondary" onClick={onRefreshClick}>
332344
Refresh

0 commit comments

Comments
 (0)