Add a timeout to waiting for the user to click on telemetry dialog

If user clicks the 'x', then the dialog goes away without its promise 
ever being resolved. This will prevent the extension from being started.

This commit uses `Promise.race` to set a 10s timeout for the dialog to
disappear and the extension to start anyway. If this happens, the
dialog will appear on next startup and will continue to appear until
the user actively clicks 'Yes' or 'No.

Author: aeisenberg

extensions/ql-vscode/package.json

@@ -179,7 +179,7 @@
           "type": "boolean",
           "default": false,
           "scope": "application",
-          "markdownDescription": "Specifies whether to enable Code QL telemetry. This setting AND the global `#telemetry.enableTelemetry#` setting must be checked for telemetry to be sent."
+          "markdownDescription": "Specifies whether to enable Code QL telemetry. This setting AND the global `#telemetry.enableTelemetry#` setting must be checked for telemetry to be sent. For more information, see [TELEMETRY.md](https://github.com/github/vscode-codeql/blob/93831e28597bb08567db9844737efd9ff188fc3a/.github/TELEMETRY.md)"
         },
         "codeQL.telemetry.logTelemetry": {
           "type": "boolean",

extensions/ql-vscode/src/telemetry.ts

@@ -127,10 +127,15 @@ async function requestTelemetryPermission(ctx: ExtensionContext) {
     // if global telemetry is disabled, avoid showing the dialog or making any changes
     let result = undefined;
     if (workspace.getConfiguration().get<boolean>('telemetry.enableTelemetry')) {
-      result = await showBinaryChoiceDialog(
-        'Do we have your permission to collect anonymous usage statistics and sanitized error reports to help us improve CodeQL for VSCode?',
-        { modal: false }
-      );
+      // Extension won't start until this completes. So, set a timeout here in order
+      // to ensure the extension continues even if the user doesn't make a choice.
+      result = await Promise.race([
+        showBinaryChoiceDialog(
+          'Do we have your permission to collect anonymous usage statistics help us improve CodeQL for VSCode? See [TELEMETRY.md](https://github.com/github/vscode-codeql/blob/93831e28597bb08567db9844737efd9ff188fc3a/.github/TELEMETRY.md)',
+          { modal: false }
+        ),
+        new Promise(resolve => setTimeout(resolve, 10000))
+      ]) as boolean | undefined;
     }
     if (result !== undefined) {
       await Promise.all([