Don't select row when clicking a button or dropdown

Author: shati-patel

extensions/ql-vscode/src/view/common/Dropdown.tsx

@@ -25,6 +25,9 @@ type Props = {
   "aria-label"?: string;
 };
 
+const stopClickPropagation = (e: React.MouseEvent) => {
+  e.stopPropagation();
+};
 /**
  * A dropdown implementation styled to look like `VSCodeDropdown`.
  *
@@ -50,6 +53,7 @@ export function Dropdown({
       value={disabled ? disabledValue : value}
       disabled={disabled}
       onChange={onChange}
+      onClick={stopClickPropagation}
       className={className}
       {...props}
     >

extensions/ql-vscode/src/view/model-editor/MethodRow.tsx

@@ -204,11 +204,23 @@ const ModelableMethodRow = forwardRef<HTMLElement | undefined, MethodRowProps>(
             <MethodClassifications method={method} />
             <MethodName {...props.method} />
             {viewState.mode === Mode.Application && (
-              <UsagesButton onClick={jumpToMethod}>
+              <UsagesButton
+                onClick={(event: React.MouseEvent) => {
+                  event.stopPropagation();
+                  jumpToMethod();
+                }}
+              >
                 {method.usages.length}
               </UsagesButton>
             )}
-            <ViewLink onClick={jumpToMethod}>View</ViewLink>
+            <ViewLink
+              onClick={(event: React.MouseEvent) => {
+                event.stopPropagation();
+                jumpToMethod();
+              }}
+            >
+              View
+            </ViewLink>
             {props.modelingInProgress && <ProgressRing />}
           </ApiOrMethodRow>
         </DataGridCell>
@@ -277,7 +289,10 @@ const ModelableMethodRow = forwardRef<HTMLElement | undefined, MethodRowProps>(
                     <CodiconRow
                       appearance="icon"
                       aria-label="Add new model"
-                      onClick={handleAddModelClick}
+                      onClick={(event: React.MouseEvent) => {
+                        event.stopPropagation();
+                        handleAddModelClick();
+                      }}
                       disabled={addModelButtonDisabled}
                     >
                       <Codicon name="add" />
@@ -286,7 +301,10 @@ const ModelableMethodRow = forwardRef<HTMLElement | undefined, MethodRowProps>(
                     <CodiconRow
                       appearance="icon"
                       aria-label="Remove model"
-                      onClick={removeModelClickedHandlers[index]}
+                      onClick={(event: React.MouseEvent) => {
+                        event.stopPropagation();
+                        removeModelClickedHandlers[index]();
+                      }}
                     >
                       <Codicon name="trash" />
                     </CodiconRow>