Skip to content

Commit bca5000

Browse files
Address comments from PR.
1 parent 4185c34 commit bca5000

2 files changed

Lines changed: 4 additions & 1 deletion

File tree

extensions/ql-vscode/src/interface.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -400,7 +400,7 @@ export class InterfaceManager extends DisposableObject {
400400
}
401401
);
402402
const resultSet = transformBqrsResultSet(schema, chunk);
403-
results.setResultCount(resultSet.schema.rows);
403+
results.setResultCount(interpretationPage?.numTotalResults || resultSet.schema.rows);
404404
const parsedResultSets: ParsedResultSets = {
405405
pageNumber: 0,
406406
pageSize,

extensions/ql-vscode/src/query-history.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ import { URLSearchParams } from 'url';
1515
import { QueryServerClient } from './queryserver-client';
1616
import { DisposableObject } from './pure/disposable-object';
1717
import { commandRunner } from './commandRunner';
18+
import { assertNever } from './pure/helpers-pure';
1819

1920
/**
2021
* query-history.ts
@@ -136,6 +137,8 @@ export class HistoryTreeDataProvider extends DisposableObject {
136137
return q1.resultCount - q2.resultCount;
137138
case SortOrder.CountDesc:
138139
return q2.resultCount - q1.resultCount;
140+
default:
141+
assertNever(this.sortOrder);
139142
}
140143
});
141144
}

0 commit comments

Comments
 (0)