Minimize changes to the legacy query server client

Only a fake implementation of a newly introduced QueryRunner method remains.

For reference, the legacy query server is fully deprecated and errors out
on the backend.

Author: d10c

extensions/ql-vscode/src/query-server/legacy/legacy-query-runner.ts

@@ -17,7 +17,6 @@ import { QueryOutputDir } from "../../run-queries-shared";
 import { QueryServerClient } from "./query-server-client";
 import {
   clearCacheInDatabase,
-  trimCacheInDatabase,
   compileAndRunQueryAgainstDatabaseCore,
 } from "./run-queries";
 import { upgradeDatabaseExplicit } from "./upgrades";
@@ -66,7 +65,9 @@ export class LegacyQueryRunner extends QueryRunner {
     dbItem: DatabaseItem,
     token: CancellationToken,
   ): Promise<void> {
-    await trimCacheInDatabase(this.qs, dbItem, token);
+    // For the sake of conforming to the QueryRunner interface, delegate to clearCacheInDatabase
+    // just for the effect of getting a legacy query server deprecation error response.
+    await clearCacheInDatabase(this.qs, dbItem, token);
   }
 
   public async compileAndRunQueryAgainstDatabaseCore(

extensions/ql-vscode/src/query-server/legacy/run-queries.ts

@@ -214,27 +214,6 @@ export async function clearCacheInDatabase(
   return qs.sendRequest(messages.clearCache, params, token);
 }
 
-export async function trimCacheInDatabase(
-  qs: qsClient.QueryServerClient,
-  dbItem: DatabaseItem,
-  token: CancellationToken,
-): Promise<messages.ClearCacheResult> {
-  if (dbItem.contents === undefined) {
-    throw new Error("Can't clear the cache in an invalid database.");
-  }
-
-  const db: messages.Dataset = {
-    dbDir: dbItem.contents.datasetUri.fsPath,
-    workingSet: "default",
-  };
-
-  const params: messages.TrimCacheParams = {
-    db,
-  };
-
-  return qs.sendRequest(messages.trimCache, params, token);
-}
-
 function reportNoUpgradePath(
   qlProgram: messages.QlProgram,
   queryDbscheme: string,