Skip to content

Commit 9ddfd58

Browse files
committed
Adds interface-types and result-keys to pure
Will ensure that these files never have vscode dependencies.
1 parent fe1476f commit 9ddfd58

20 files changed

Lines changed: 36 additions & 31 deletions

extensions/ql-vscode/src/cli.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ import { BQRSInfo, DecodedBqrsChunk } from './pure/bqrs-cli-types';
1515
import { CliConfig } from './config';
1616
import { DistributionProvider, FindDistributionResultKind } from './distribution';
1717
import { assertNever } from './pure/helpers-pure';
18-
import { QueryMetadata, SortDirection } from './interface-types';
18+
import { QueryMetadata, SortDirection } from './pure/interface-types';
1919
import { Logger, ProgressReporter } from './logging';
2020

2121
/**
@@ -702,7 +702,7 @@ export class CodeQLCliServer implements Disposable {
702702

703703
private async refreshVersion() {
704704
const distribution = await this.distributionProvider.getDistribution();
705-
switch(distribution.kind) {
705+
switch (distribution.kind) {
706706
case FindDistributionResultKind.CompatibleDistribution:
707707
// eslint-disable-next-line no-fallthrough
708708
case FindDistributionResultKind.IncompatibleDistribution:

extensions/ql-vscode/src/compare/compare-interface.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ import {
1414
FromCompareViewMessage,
1515
ToCompareViewMessage,
1616
QueryCompareResult,
17-
} from '../interface-types';
17+
} from '../pure/interface-types';
1818
import { Logger } from '../logging';
1919
import { CodeQLCliServer } from '../cli';
2020
import { DatabaseManager } from '../databases';

extensions/ql-vscode/src/compare/resultsDiff.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { RawResultSet } from '../pure/bqrs-cli-types';
2-
import { QueryCompareResult } from '../interface-types';
2+
import { QueryCompareResult } from '../pure/interface-types';
33

44
/**
55
* Compare the rows of two queries. Use deep equality to determine if

extensions/ql-vscode/src/compare/view/Compare.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import * as Rdom from 'react-dom';
55
import {
66
ToCompareViewMessage,
77
SetComparisonsMessage,
8-
} from '../../interface-types';
8+
} from '../../pure/interface-types';
99
import CompareSelector from './CompareSelector';
1010
import { vscode } from '../../view/vscode-api';
1111
import CompareTable from './CompareTable';

extensions/ql-vscode/src/compare/view/CompareTable.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import * as React from 'react';
22

3-
import { SetComparisonsMessage } from '../../interface-types';
3+
import { SetComparisonsMessage } from '../../pure/interface-types';
44
import RawTableHeader from '../../view/RawTableHeader';
55
import { className } from '../../view/result-table-utils';
66
import { ResultRow } from '../../pure/bqrs-cli-types';

extensions/ql-vscode/src/interface-utils.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ import {
1717
isLineColumnLoc
1818
} from './pure/bqrs-utils';
1919
import { DatabaseItem, DatabaseManager } from './databases';
20-
import { ViewSourceFileMsg } from './interface-types';
20+
import { ViewSourceFileMsg } from './pure/interface-types';
2121
import { Logger } from './logging';
2222
import {
2323
LineColumnLocation,

extensions/ql-vscode/src/interface.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ import {
3030
INTERPRETED_RESULTS_PAGE_SIZE,
3131
ALERTS_TABLE_NAME,
3232
RawResultsSortState,
33-
} from './interface-types';
33+
} from './pure/interface-types';
3434
import { Logger } from './logging';
3535
import { commandRunner } from './helpers';
3636
import * as messages from './pure/messages';
@@ -46,7 +46,7 @@ import {
4646
shownLocationLineDecoration,
4747
jumpToLocation,
4848
} from './interface-utils';
49-
import { getDefaultResultSetName, ParsedResultSets } from './interface-types';
49+
import { getDefaultResultSetName, ParsedResultSets } from './pure/interface-types';
5050
import { RawResultSet, transformBqrsResultSet, ResultSetSchema } from './pure/bqrs-cli-types';
5151

5252
/**

extensions/ql-vscode/src/interface-types.ts renamed to extensions/ql-vscode/src/pure/interface-types.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import * as sarif from 'sarif';
2-
import { RawResultSet, ResultRow, ResultSetSchema, Column, ResolvableLocationValue } from './pure/bqrs-cli-types';
2+
import { RawResultSet, ResultRow, ResultSetSchema, Column, ResolvableLocationValue } from './bqrs-cli-types';
33

44
/**
55
* This module contains types and code that are shared between
File renamed without changes.

extensions/ql-vscode/src/query-results.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import * as cli from './cli';
66
import * as sarif from 'sarif';
77
import * as fs from 'fs-extra';
88
import * as path from 'path';
9-
import { RawResultsSortState, SortedResultSetInfo, DatabaseInfo, QueryMetadata, InterpretedResultsSortState, ResultsPaths } from './interface-types';
9+
import { RawResultsSortState, SortedResultSetInfo, DatabaseInfo, QueryMetadata, InterpretedResultsSortState, ResultsPaths } from './pure/interface-types';
1010
import { QueryHistoryConfig } from './config';
1111
import { QueryHistoryItemOptions } from './query-history';
1212

@@ -96,8 +96,8 @@ export class CompletedQuery implements QueryWithResults {
9696
}
9797

9898
getLabel(): string {
99-
return this.options?.label
100-
|| this.config.format;
99+
return this.options?.label
100+
|| this.config.format;
101101
}
102102

103103
get didRunSuccessfully(): boolean {

0 commit comments

Comments
 (0)