Fix and add tests.

Author: starcke

extensions/ql-vscode/test/__mocks__/appMock.ts

@@ -56,7 +56,7 @@ class MockAppEventEmitter<T> implements AppEventEmitter<T> {
 
   constructor() {
     this.event = () => {
-      return {} as Disposable;
+      return new MockAppEvent();
     };
   }
 
@@ -69,6 +69,16 @@ class MockAppEventEmitter<T> implements AppEventEmitter<T> {
   }
 }
 
+class MockAppEvent implements Disposable {
+  public fire(): void {
+    // no-op
+  }
+
+  public dispose() {
+    // no-op
+  }
+}
+
 export function createMockEnvironmentContext(): EnvironmentContext {
   return {
     language: "en-US",

extensions/ql-vscode/test/factories/query-history/local-query-history-item.ts

@@ -7,6 +7,7 @@ import {
 import { CancellationTokenSource } from "vscode";
 import { QueryResultType } from "../../../src/query-server/legacy-messages";
 import { QueryMetadata } from "../../../src/common/interface-types";
+import { QueryLanguage } from "../../../src/common/query-language";
 
 export function createMockLocalQueryInfo({
   startTime = new Date(),
@@ -16,6 +17,7 @@ export function createMockLocalQueryInfo({
   dbName = "db-name",
   hasMetadata = false,
   queryWithResults = undefined,
+  language = undefined,
 }: {
   startTime?: Date;
   resultCount?: number;
@@ -24,6 +26,7 @@ export function createMockLocalQueryInfo({
   dbName?: string;
   hasMetadata?: boolean;
   queryWithResults?: QueryWithResults | undefined;
+  language?: QueryLanguage;
 }): LocalQueryInfo {
   const cancellationToken = {
     dispose: () => {
@@ -40,6 +43,7 @@ export function createMockLocalQueryInfo({
     databaseInfo: {
       databaseUri: "databaseUri",
       name: dbName,
+      language,
     },
     start: startTime,
     id: faker.number.int().toString(),

extensions/ql-vscode/test/factories/query-history/variant-analysis-history-item.ts

@@ -5,6 +5,7 @@ import {
   VariantAnalysisStatus,
 } from "../../../src/variant-analysis/shared/variant-analysis";
 import { createMockVariantAnalysis } from "../variant-analysis/shared/variant-analysis";
+import { QueryLanguage } from "../../../src/common/query-language";
 
 export function createMockVariantAnalysisHistoryItem({
   historyItemStatus = QueryStatus.InProgress,
@@ -14,6 +15,7 @@ export function createMockVariantAnalysisHistoryItem({
   userSpecifiedLabel = undefined,
   executionStartTime = undefined,
   variantAnalysis = undefined,
+  language = QueryLanguage.Javascript,
 }: {
   historyItemStatus?: QueryStatus;
   variantAnalysisStatus?: VariantAnalysisStatus;
@@ -22,6 +24,7 @@ export function createMockVariantAnalysisHistoryItem({
   userSpecifiedLabel?: string;
   executionStartTime?: number;
   variantAnalysis?: VariantAnalysis;
+  language?: QueryLanguage;
 }): VariantAnalysisHistoryItem {
   return {
     t: "variant-analysis",
@@ -34,6 +37,7 @@ export function createMockVariantAnalysisHistoryItem({
       createMockVariantAnalysis({
         status: variantAnalysisStatus,
         executionStartTime,
+        language,
       }),
     userSpecifiedLabel,
   };

extensions/ql-vscode/test/factories/variant-analysis/shared/variant-analysis.ts

@@ -15,11 +15,13 @@ export function createMockVariantAnalysis({
   scannedRepos = createMockScannedRepos(),
   skippedRepos = createMockSkippedRepos(),
   executionStartTime = faker.number.int(),
+  language = QueryLanguage.Javascript,
 }: {
   status?: VariantAnalysisStatus;
   scannedRepos?: VariantAnalysisScannedRepository[];
   skippedRepos?: VariantAnalysisSkippedRepositories;
   executionStartTime?: number | undefined;
+  language: QueryLanguage;
 }): VariantAnalysis {
   return {
     id: faker.number.int(),
@@ -32,7 +34,7 @@ export function createMockVariantAnalysis({
     query: {
       name: "a-query-name",
       filePath: "a-query-file-path",
-      language: QueryLanguage.Javascript,
+      language,
       text: "a-query-text",
     },
     databases: {

extensions/ql-vscode/test/vscode-tests/no-workspace/query-history/history-tree-data-provider.test.ts

@@ -28,9 +28,13 @@ import {
 import { QueryHistoryManager } from "../../../../src/query-history/query-history-manager";
 import { createMockQueryHistoryDirs } from "../../../factories/query-history/query-history-dirs";
 import { createMockApp } from "../../../__mocks__/appMock";
+import { LanguageContextStore } from "../../../../src/language-context-store";
+import { App } from "../../../../src/common/app";
+import { QueryLanguage } from "../../../../src/common/query-language";
 
 describe("HistoryTreeDataProvider", () => {
   const mockExtensionLocation = join(tmpDir.name, "mock-extension-location");
+  let app: App;
   let configListener: QueryHistoryConfigListener;
   const doCompareCallback = jest.fn();
 
@@ -45,10 +49,12 @@ describe("HistoryTreeDataProvider", () => {
 
   let historyTreeDataProvider: HistoryTreeDataProvider;
   let labelProvider: HistoryItemLabelProvider;
+  let languageContext: LanguageContextStore;
 
   beforeEach(() => {
     jest.spyOn(extLogger, "log").mockResolvedValue(undefined);
 
+    app = createMockApp({});
     configListener = new QueryHistoryConfigListener();
     localQueriesResultsViewStub = {
       showResults: jest.fn(),
@@ -124,7 +130,11 @@ describe("HistoryTreeDataProvider", () => {
       ttlInMillis: 0,
       onDidChangeConfiguration: jest.fn(),
     });
-    historyTreeDataProvider = new HistoryTreeDataProvider(labelProvider);
+    languageContext = new LanguageContextStore(app);
+    historyTreeDataProvider = new HistoryTreeDataProvider(
+      labelProvider,
+      languageContext,
+    );
   });
 
   afterEach(async () => {
@@ -418,11 +428,68 @@ describe("HistoryTreeDataProvider", () => {
         expect(children).toEqual(expected);
       });
     });
+
+    describe("filtering", () => {
+      const history = [
+        createMockLocalQueryInfo({
+          userSpecifiedLabel: "a",
+          // No language at all => unknown
+        }),
+        createMockVariantAnalysisHistoryItem({
+          userSpecifiedLabel: "b",
+          // No specified language => javascript
+        }),
+        createMockLocalQueryInfo({
+          userSpecifiedLabel: "c",
+          language: QueryLanguage.Python,
+        }),
+        createMockVariantAnalysisHistoryItem({
+          userSpecifiedLabel: "d",
+          language: QueryLanguage.Java,
+        }),
+      ];
+
+      let treeDataProvider: HistoryTreeDataProvider;
+
+      beforeEach(async () => {
+        queryHistoryManager = await createMockQueryHistory(allHistory);
+        (queryHistoryManager.treeDataProvider as any).history = [...history];
+        treeDataProvider = queryHistoryManager.treeDataProvider;
+      });
+
+      it("should get all if no filter is provided", async () => {
+        const expected = [history[0], history[1], history[2], history[3]];
+        treeDataProvider.sortOrder = SortOrder.NameAsc;
+
+        const children = await treeDataProvider.getChildren();
+        expect(children).toEqual(expected);
+      });
+
+      it("should filter local runs by language", async () => {
+        const expected = [history[3]];
+        treeDataProvider.sortOrder = SortOrder.NameAsc;
+
+        await languageContext.setLanguageContext(QueryLanguage.Java);
+
+        const children = await treeDataProvider.getChildren();
+        expect(children).toEqual(expected);
+      });
+
+      it("should filter variant analysis runs by language", async () => {
+        const expected = [history[2]];
+        treeDataProvider.sortOrder = SortOrder.NameAsc;
+
+        await languageContext.setLanguageContext(QueryLanguage.Python);
+
+        const children = await treeDataProvider.getChildren();
+        expect(children).toEqual(expected);
+      });
+    });
   });
 
   async function createMockQueryHistory(allHistory: QueryHistoryInfo[]) {
     const qhm = new QueryHistoryManager(
-      createMockApp({}),
+      app,
       {} as QueryRunner,
       {} as DatabaseManager,
       localQueriesResultsViewStub,
@@ -439,6 +506,7 @@ describe("HistoryTreeDataProvider", () => {
         ttlInMillis: 0,
         onDidChangeConfiguration: jest.fn(),
       }),
+      languageContext,
       doCompareCallback,
     );
     (qhm.treeDataProvider as any).history = [...allHistory];

extensions/ql-vscode/test/vscode-tests/no-workspace/query-history/query-history-manager.test.ts

@@ -28,6 +28,7 @@ import { createMockQueryHistoryDirs } from "../../../factories/query-history/que
 import { createMockApp } from "../../../__mocks__/appMock";
 import { App } from "../../../../src/common/app";
 import { createMockCommandManager } from "../../../__mocks__/commandsMock";
+import { LanguageContextStore } from "../../../../src/language-context-store";
 
 describe("QueryHistoryManager", () => {
   const mockExtensionLocation = join(tmpDir.name, "mock-extension-location");
@@ -937,6 +938,7 @@ describe("QueryHistoryManager", () => {
         ttlInMillis: 0,
         onDidChangeConfiguration: jest.fn(),
       }),
+      new LanguageContextStore(mockApp),
       doCompareCallback,
     );
     (qhm.treeDataProvider as any).history = [...allHistory];

extensions/ql-vscode/test/vscode-tests/no-workspace/query-history/variant-analysis-history.test.ts

@@ -23,6 +23,7 @@ import { QueryHistoryManager } from "../../../../src/query-history/query-history
 import { mockedObject } from "../../utils/mocking.helpers";
 import { createMockQueryHistoryDirs } from "../../../factories/query-history/query-history-dirs";
 import { createMockApp } from "../../../__mocks__/appMock";
+import { LanguageContextStore } from "../../../../src/language-context-store";
 
 // set a higher timeout since recursive delete may take a while, expecially on Windows.
 jest.setTimeout(120000);
@@ -74,8 +75,10 @@ describe("Variant Analyses and QueryHistoryManager", () => {
       join(STORAGE_DIR, "workspace-query-history.json"),
     ).queries;
 
+    const app = createMockApp({});
+
     qhm = new QueryHistoryManager(
-      createMockApp({}),
+      app,
       {} as QueryRunner,
       {} as DatabaseManager,
       localQueriesResultsViewStub,
@@ -97,6 +100,7 @@ describe("Variant Analyses and QueryHistoryManager", () => {
         ttlInMillis: 0,
         onDidChangeConfiguration: jest.fn(),
       }),
+      new LanguageContextStore(app),
       asyncNoop,
     );
     disposables.push(qhm);