Update the release workflow

Only do a version bump if this is run as part of the release process.

Author: aeisenberg

.github/workflows/release.yml

@@ -20,8 +20,6 @@ jobs:
   build:
     name: Release
     runs-on: ubuntu-latest
-    env:
-      APP_INSIGHTS_KEY: '${{ secrets.APP_INSIGHTS_KEY }}'
     steps:
       - name: Checkout
         uses: actions/checkout@v2
@@ -37,7 +35,10 @@ jobs:
         shell: bash
 
       - name: Build
+        env:
+          APP_INSIGHTS_KEY: '${{ secrets.APP_INSIGHTS_KEY }}'
         run: |
+          echo "APP INSIGHTS KEY LENGTH: ${#APP_INSIGHTS_KEY}"
           cd extensions/ql-vscode
           npm run build -- --release
         shell: bash
@@ -58,7 +59,6 @@ jobs:
 
       # Uploading artifacts is not necessary to create a release.
       # This is just in case the release itself fails and we want to access the built artifacts from Actions.
-      # TODO Remove if not useful.
       - name: Upload artifacts
         uses: actions/upload-artifact@v2
         with:
@@ -69,6 +69,7 @@ jobs:
 
       - name: Create release
         id: create-release
+        if: github.event_name == 'pull_request'
         uses: actions/create-release@v1.0.0
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
@@ -83,7 +84,7 @@ jobs:
 
       - name: Upload release asset
         uses: actions/upload-release-asset@v1.0.1
-        if: success()
+        if: success() && github.event_name == 'pull_request'
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
         with:
@@ -94,16 +95,27 @@ jobs:
           asset_name: ${{ format('vscode-codeql-{0}.vsix', steps.prepare-artifacts.outputs.ref_name) }}
           asset_content_type: application/zip
 
+
+      - name: No Release
+        if: github.event_name != 'pull_request'
+        run: |
+          echo "Not making a release because this is not a pull request"
+
+      ###
+      # Do Post release work: version bump and changelog PR
+      # Only do this if we are running from a PR (ie- this is part of the release process)
+
       # The checkout action does not fetch the main branch.
       # Fetch the main branch so that we can base the version bump PR against main.
       - name: Fetch main branch
+        if: github.event_name == 'pull_request'
         run: |
           git fetch --depth=1 origin main:main
           git checkout main
 
       - name: Bump patch version
         id: bump-patch-version
-        if: success()
+        if: success() && github.event_name == 'pull_request'
         run: |
           cd extensions/ql-vscode
           # Bump to the next patch version. Major or minor version bumps will have to be done manually.
@@ -112,14 +124,14 @@ jobs:
           echo "::set-output name=next_version::$NEXT_VERSION"
 
       - name: Add changelog for next release
-        if: success()
+        if: success() && github.event_name == 'pull_request'
         run: |
           cd extensions/ql-vscode
           perl -i -pe 's/^/## \[UNRELEASED\]\n\n/ if($.==3)' CHANGELOG.md
 
       - name: Create version bump PR
         uses: peter-evans/create-pull-request@c7f493a8000b8aeb17a1332e326ba76b57cb83eb # v3.4.1
-        if: success()
+        if: success() && github.event_name == 'pull_request'
         with:
           token: ${{ secrets.GITHUB_TOKEN }}
           commit-message: Bump version to ${{ steps.bump-patch-version.outputs.next_version }}