Continue work on streaming for SARIF files

Author: marcnjaramillo

extensions/ql-vscode/package-lock.json

@@ -958,6 +958,7 @@
   },
   "dependencies": {
     "@octokit/rest": "^18.5.6",
+    "@types/stream-chain": "^2.0.1",
     "@types/stream-json": "^1.7.1",
     "child-process-promise": "^2.2.1",
     "classnames": "~2.2.6",
@@ -970,6 +971,7 @@
     "react": "^16.8.6",
     "react-dom": "^16.8.6",
     "semver": "~7.3.2",
+    "stream-chain": "^2.2.4",
     "stream-json": "^1.7.3",
     "tmp": "^0.1.0",
     "tmp-promise": "~3.0.2",

extensions/ql-vscode/package.json

@@ -2,7 +2,9 @@ import * as cpp from 'child-process-promise';
 import * as child_process from 'child_process';
 import * as fs from 'fs-extra';
 import * as path from 'path';
+import { chain } from 'stream-chain';
 import { Parser } from 'stream-json';
+import Assembler = require('stream-json/Assembler');
 import * as sarif from 'sarif';
 import { SemVer } from 'semver';
 import { Readable } from 'stream';
@@ -670,10 +672,16 @@ export class CodeQLCliServer implements Disposable {
 
   async interpretBqrs(metadata: QueryMetadata, resultsPath: string, interpretedResultsPath: string, sourceInfo?: SourceInfo): Promise<sarif.Log> {
     await this.runInterpretCommand(SARIF_FORMAT, metadata, resultsPath, interpretedResultsPath, sourceInfo);
-    const parsedSarif = new Parser();
-    let output: Parser;
+    
+    const pipeline = chain([
+      fs.createReadStream(interpretedResultsPath),
+      new Parser()
+    ]);
+    
+    const asm = Assembler.connectTo(pipeline);
+    asm.on('done', asm => console.log(asm.current));
     try {
-      output = fs.createReadStream(interpretedResultsPath).pipe(parsedSarif);
+      // output = fs.createReadStream('/Users/marcjaramillo/MLH/vscode-codeql-starter/jdk11-tainted-path.sarif').pipe(parsedSarif);
     } catch (e) {
       const rawMessage = e.stderr || e.message;
       const errorMessage = rawMessage.startsWith('Cannot create a string')
@@ -682,7 +690,11 @@ export class CodeQLCliServer implements Disposable {
       throw new Error(`Reading output of interpretation failed: ${errorMessage}`);
     }
     try {
-      return output as unknown as sarif.Log;
+      // output.on('data', data => {
+      //   console.log(data);
+      // });
+      // output.on('end', () => { console.log('done'); });
+      return {} as unknown as sarif.Log;
     } catch (err) {
       throw new Error(`Parsing output of interpretation failed: ${err.stderr || err}`);
     }