Skip to content

Commit 53d8260

Browse files
author
Alexander Eyers-Taylor
committed
QuickEval:Address review comments
1 parent 8ad1fd7 commit 53d8260

2 files changed

Lines changed: 4 additions & 2 deletions

File tree

extensions/ql-vscode/CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,8 @@
1515
- Add warning when using unsupported CodeQL CLI version. [#2428](https://github.com/github/vscode-codeql/pull/2428)
1616
- Retry variant analysis results download if connection times out. [#2440](https://github.com/github/vscode-codeql/pull/2440)
1717
- Add `CodeQL: Quick Evaluation Count` command to generate the count of the selected item without having to compute locations or strings.
18+
- Add `CodeQL: Quick Evaluation Count` command to generate the count summary statistics of the results set
19+
without speding the time to compute locations and strings.
1820

1921
## 1.8.4 - 3 May 2023
2022

extensions/ql-vscode/src/local-queries/local-queries.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ import {
4040
import { CompletedLocalQueryInfo, LocalQueryInfo } from "../query-results";
4141
import { WebviewReveal } from "./webview";
4242
import { asError, getErrorMessage } from "../common/helpers-pure";
43-
import { CodeQLCliServer } from "../codeql-cli/cli";
43+
import { CliVersionConstraint, CodeQLCliServer } from "../codeql-cli/cli";
4444
import { LocalQueryCommands } from "../common/commands";
4545
import { App } from "../common/app";
4646
import { DisposableObject } from "../common/disposable-object";
@@ -246,7 +246,7 @@ export class LocalQueries extends DisposableObject {
246246
async (progress, token) => {
247247
if (!(await this.cliServer.cliConstraints.supportsQuickEvalCount())) {
248248
throw new Error(
249-
"Quick evaluation counts is not supported by this version of CodeQL CLI.",
249+
`Quick evaluation count is only supported by CodeQL CLI v${CliVersionConstraint.CLI_VERSION_WITH_QUICK_EVAL_COUNT} or later.`,
250250
);
251251
}
252252
await this.compileAndRunQuery(

0 commit comments

Comments
 (0)