Fix Unhandled arguments bug

When we added an extra optional param `isTutorialDatabase` to
`openDatabase` [1] , the tests all passed but there is at least one call
[2] where this triggers an `Unhandled arguments` error.

This is because the method call doesn't know which optional param
we're passing.

Let's revert back to the original method signature where we had just
one optional parameter (the database name) and set it to a special
"CodeQL Tutorial Database" value.

We can then use this to understand that the extension is running in
the codespace and we want to skip creating a skeleton pack for it
since it's the tutorial database.

[1]: https://github.com/github/vscode-codeql/blob/5e51bb57f5f76b57768fb6a3543f153f5752c23c/extensions/ql-vscode/src/local-databases.ts#L610
[2]: https://github.com/github/vscode-codeql/blob/5e51bb57f5f76b57768fb6a3543f153f5752c23c/extensions/ql-vscode/src/databaseFetcher.ts#L257-L262

Author: elenatanasoiu

extensions/ql-vscode/src/local-databases-ui.ts

@@ -379,14 +379,12 @@ export class DatabaseUI extends DisposableObject {
         );
 
         let databaseItem = this.databaseManager.findDatabaseItem(uri);
-        const isTutorialDatabase = true;
         if (databaseItem === undefined) {
           databaseItem = await this.databaseManager.openDatabase(
             progress,
             token,
             uri,
             "CodeQL Tutorial Database",
-            isTutorialDatabase,
           );
         }
         await this.databaseManager.setCurrentDatabaseItem(databaseItem);

extensions/ql-vscode/src/local-databases.ts

@@ -607,7 +607,6 @@ export class DatabaseManager extends DisposableObject {
     token: vscode.CancellationToken,
     uri: vscode.Uri,
     displayName?: string,
-    isTutorialDatabase?: boolean,
   ): Promise<DatabaseItem> {
     const contents = await DatabaseResolver.resolveDatabaseContents(uri);
     // Ignore the source archive for QLTest databases by default.
@@ -631,7 +630,7 @@ export class DatabaseManager extends DisposableObject {
     await this.addDatabaseItem(progress, token, databaseItem);
     await this.addDatabaseSourceArchiveFolder(databaseItem);
 
-    if (isCodespacesTemplate() && !isTutorialDatabase) {
+    if (isCodespacesTemplate() && displayName !== "CodeQL Tutorial Database") {
       await this.createSkeletonPacks(databaseItem);
     }
 

extensions/ql-vscode/test/vscode-tests/minimal-workspace/local-databases.test.ts

@@ -715,14 +715,11 @@ describe("local databases", () => {
         it("should not offer to create a skeleton QL pack", async () => {
           jest.spyOn(Setting.prototype, "getValue").mockReturnValue(true);
 
-          const isTutorialDatabase = true;
-
           await databaseManager.openDatabase(
             {} as ProgressCallback,
             {} as CancellationToken,
             mockDbItem.databaseUri,
             "CodeQL Tutorial Database",
-            isTutorialDatabase,
           );
 
           expect(createSkeletonPacksSpy).toBeCalledTimes(0);