Fix tests

Author: shati-patel

extensions/ql-vscode/test/vscode-tests/minimal-workspace/local-queries/local-databases.test.ts

@@ -20,7 +20,7 @@ import {
 import { testDisposeHandler } from "../../test-dispose-handler";
 import { QueryRunner } from "../../../../src/query-server/query-runner";
 import * as dialog from "../../../../src/common/vscode/dialog";
-import { Setting } from "../../../../src/config";
+import * as config from "../../../../src/config";
 import { QlPackGenerator } from "../../../../src/local-queries/qlpack-generator";
 import { mockedObject } from "../../utils/mocking.helpers";
 import { createMockApp } from "../../../__mocks__/appMock";
@@ -626,7 +626,10 @@ describe("local databases", () => {
         showNeverAskAgainDialogSpy = jest
           .spyOn(dialog, "showNeverAskAgainDialog")
           .mockResolvedValue("No, and never ask me again");
-        const updateValueSpy = jest.spyOn(Setting.prototype, "updateValue");
+        const updateValueSpy = jest.spyOn(
+          config.Setting.prototype,
+          "updateValue",
+        );
 
         await (databaseManager as any).createSkeletonPacks(mockDbItem);
 
@@ -726,7 +729,17 @@ describe("local databases", () => {
       expect(setCurrentDatabaseItemSpy).toBeCalledTimes(1);
     });
 
-    it("should add database source archive folder", async () => {
+    it("should not add database source archive folder when `codeQL.databaseDownload.addDatabaseSourceToWorkspace` is `false`", async () => {
+      jest.spyOn(config, "addDatabaseSourceToWorkspace").mockReturnValue(false);
+
+      await databaseManager.openDatabase(mockDbItem.databaseUri);
+
+      expect(addDatabaseSourceArchiveFolderSpy).toBeCalledTimes(0);
+    });
+
+    it("should add database source archive folder when `codeQL.databaseDownload.addDatabaseSourceToWorkspace` is `true`", async () => {
+      jest.spyOn(config, "addDatabaseSourceToWorkspace").mockReturnValue(true);
+
       await databaseManager.openDatabase(mockDbItem.databaseUri);
 
       expect(addDatabaseSourceArchiveFolderSpy).toBeCalledTimes(1);
@@ -735,7 +748,9 @@ describe("local databases", () => {
     describe("when codeQL.codespacesTemplate is set to true", () => {
       describe("when we add the tutorial database to the codespace", () => {
         it("should not offer to create a skeleton QL pack", async () => {
-          jest.spyOn(Setting.prototype, "getValue").mockReturnValue(true);
+          jest
+            .spyOn(config.Setting.prototype, "getValue")
+            .mockReturnValue(true);
 
           const isTutorialDatabase = true;
           const makeSelected = true;
@@ -754,7 +769,9 @@ describe("local databases", () => {
 
       describe("when we add a new database that isn't the tutorial one", () => {
         it("should create a skeleton QL pack", async () => {
-          jest.spyOn(Setting.prototype, "getValue").mockReturnValue(true);
+          jest
+            .spyOn(config.Setting.prototype, "getValue")
+            .mockReturnValue(true);
 
           await databaseManager.openDatabase(mockDbItem.databaseUri);
 
@@ -765,7 +782,7 @@ describe("local databases", () => {
 
     describe("when codeQL.codespacesTemplate is set to false", () => {
       it("should not create a skeleton QL pack", async () => {
-        jest.spyOn(Setting.prototype, "getValue").mockReturnValue(false);
+        jest.spyOn(config.Setting.prototype, "getValue").mockReturnValue(false);
 
         await databaseManager.openDatabase(mockDbItem.databaseUri);
         expect(createSkeletonPacksSpy).toBeCalledTimes(0);
@@ -774,7 +791,9 @@ describe("local databases", () => {
 
     describe("when codeQL.codespacesTemplate is not set", () => {
       it("should not create a skeleton QL pack", async () => {
-        jest.spyOn(Setting.prototype, "getValue").mockReturnValue(undefined);
+        jest
+          .spyOn(config.Setting.prototype, "getValue")
+          .mockReturnValue(undefined);
 
         await databaseManager.openDatabase(mockDbItem.databaseUri);
         expect(createSkeletonPacksSpy).toBeCalledTimes(0);