Fix Code Scanning warnings

Author: aeisenberg

extensions/ql-vscode/src/test-adapter.ts

@@ -220,14 +220,13 @@ export class QLTestAdapter extends DisposableObject implements TestAdapter {
       const state = event.pass
         ? 'passed'
         : event.messages?.length
-        ? 'errored'
-        : 'failed';
+          ? 'errored'
+          : 'failed';
       let message: string | undefined;
       if (event.diff?.length) {
         message = ['', `${state}: ${event.test}`, ...event.diff, ''].join('\n');
         testLogger.log(message);
       }
-      (event.diff || []).join('\n');
       this._testStates.fire({
         type: 'test',
         state,

extensions/ql-vscode/src/vscode-tests/no-workspace/distribution.test.ts

@@ -214,7 +214,6 @@ describe('Launcher path', () => {
 
   it('should warn when using a hard-coded deprecated launcher name', async () => {
     launcherThatExists = 'codeql.cmd';
-    path.sep;
     const result = await getExecutableFromDirectory('abc');
     expect(fsSpy).to.have.been.calledWith(pathToExe);
     expect(fsSpy).to.have.been.calledWith(pathToCmd);