Make All the default filter value

Author: shati-patel

extensions/ql-vscode/CHANGELOG.md

@@ -2,7 +2,8 @@
 
 ## [UNRELEASED]
 
-- Add settings `codeQL.variantAnalysis.defaultResultsFilter` and `codeQL.variantAnalysis.defaultResultsSort` for configuring how variant analysis results are filtered and sorted in the results view. The default is to show only repositories with results, and to sort by the number of results. [#2392](https://github.com/github/vscode-codeql/pull/2392)
+- Add settings `codeQL.variantAnalysis.defaultResultsFilter` and `codeQL.variantAnalysis.defaultResultsSort` for configuring how variant analysis results are filtered and sorted in the results view. The default is to show all repositories, and to sort by the number of results. [#2392](https://github.com/github/vscode-codeql/pull/2392)
+
 ## 1.8.4 - 3 May 2023
 
 - Avoid repeated error messages when unable to monitor a variant analysis. [#2396](https://github.com/github/vscode-codeql/pull/2396)

extensions/ql-vscode/package.json

@@ -331,7 +331,7 @@
         },
         "codeQL.variantAnalysis.defaultResultsFilter": {
           "type": "string",
-          "default": "withResults",
+          "default": "all",
           "enum": [
             "all",
             "withResults"

extensions/ql-vscode/src/pure/variant-analysis-filter-sort.ts

@@ -29,7 +29,7 @@ export type RepositoriesFilterSortStateWithIds = RepositoriesFilterSortState & {
 
 export const defaultFilterSortState: RepositoriesFilterSortState = {
   searchValue: "",
-  filterKey: FilterKey.WithResults,
+  filterKey: FilterKey.All,
   sortKey: SortKey.NumberOfResults,
 };
 

extensions/ql-vscode/src/view/variant-analysis/__tests__/VariantAnalysis.spec.tsx

@@ -54,22 +54,22 @@ describe(VariantAnalysis.name, () => {
     const variantAnalysis = createMockVariantAnalysis({});
     render({ variantAnalysis });
 
-    await waitFor(() => screen.getByDisplayValue("With results"));
+    await waitFor(() => screen.getByDisplayValue("All"));
     await waitFor(() => screen.getByDisplayValue("Number of results"));
 
     await postMessage<ToVariantAnalysisMessage>({
       t: "setFilterSortState",
       filterSortState: {
         searchValue: "",
-        filterKey: FilterKey.All,
+        filterKey: FilterKey.WithResults,
         sortKey: SortKey.Alphabetically,
       },
     });
 
-    expect(screen.getByDisplayValue("All")).toBeInTheDocument();
+    expect(screen.getByDisplayValue("With results")).toBeInTheDocument();
     expect(screen.getByDisplayValue("Alphabetically")).toBeInTheDocument();
 
-    expect(screen.queryByDisplayValue("With results")).not.toBeInTheDocument();
+    expect(screen.queryByDisplayValue("All")).not.toBeInTheDocument();
     expect(
       screen.queryByDisplayValue("Number of results"),
     ).not.toBeInTheDocument();