-
Notifications
You must be signed in to change notification settings - Fork 226
Expand file tree
/
Copy pathdistribution.test.ts
More file actions
157 lines (126 loc) · 4.5 KB
/
distribution.test.ts
File metadata and controls
157 lines (126 loc) · 4.5 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
import * as log from "../../../../src/common/logging/notifications";
import { extLogger } from "../../../../src/common/logging/vscode";
import { writeFile } from "fs-extra";
import { join } from "path";
import * as os from "os";
import type { DirectoryResult } from "tmp-promise";
import { dir } from "tmp-promise";
import {
DistributionManager,
getExecutableFromDirectory,
} from "../../../../src/codeql-cli/distribution";
import type {
showAndLogErrorMessage,
showAndLogWarningMessage,
} from "../../../../src/common/logging";
import { createMockLogger } from "../../../__mocks__/loggerMock";
jest.mock("os", () => {
const original = jest.requireActual("os");
return {
...original,
platform: jest.fn(),
};
});
const mockedOS = jest.mocked(os);
describe("Launcher path", () => {
let warnSpy: jest.SpiedFunction<typeof showAndLogWarningMessage>;
let errorSpy: jest.SpiedFunction<typeof showAndLogErrorMessage>;
let logSpy: jest.SpiedFunction<typeof extLogger.log>;
let directory: DirectoryResult;
let pathToCmd: string;
let pathToExe: string;
beforeEach(async () => {
warnSpy = jest
.spyOn(log, "showAndLogWarningMessage")
.mockResolvedValue(undefined);
errorSpy = jest
.spyOn(log, "showAndLogErrorMessage")
.mockResolvedValue(undefined);
logSpy = jest.spyOn(extLogger, "log").mockResolvedValue(undefined);
mockedOS.platform.mockReturnValue("win32");
directory = await dir({
unsafeCleanup: true,
});
pathToCmd = join(directory.path, "codeql.cmd");
pathToExe = join(directory.path, "codeql.exe");
});
afterEach(async () => {
await directory.cleanup();
});
it("should not warn with proper launcher name", async () => {
await writeFile(pathToExe, "");
const result = await getExecutableFromDirectory(directory.path);
// no warning message
expect(warnSpy).not.toHaveBeenCalled();
// No log message
expect(logSpy).not.toHaveBeenCalled();
expect(result).toBe(pathToExe);
});
it("should warn when using a hard-coded deprecated launcher name", async () => {
await writeFile(pathToCmd, "");
const result = await getExecutableFromDirectory(directory.path);
// Should have opened a warning message
expect(warnSpy).toHaveBeenCalled();
// No log message
expect(logSpy).not.toHaveBeenCalled();
expect(result).toBe(pathToCmd);
});
it("should avoid warn when no launcher is found", async () => {
const result = await getExecutableFromDirectory(directory.path, false);
// no warning message
expect(warnSpy).not.toHaveBeenCalled();
// log message sent out
expect(logSpy).not.toHaveBeenCalled();
expect(result).toBeUndefined();
});
it("should warn when no launcher is found", async () => {
const result = await getExecutableFromDirectory("abc", true);
// no warning message
expect(warnSpy).not.toHaveBeenCalled();
// log message sent out
expect(logSpy).toHaveBeenCalled();
expect(result).toBeUndefined();
});
it("should not warn when deprecated launcher is used, but no new launcher is available", async function () {
await writeFile(pathToCmd, "");
const manager = new DistributionManager(
{ customCodeQlPath: pathToCmd } as any,
{} as any,
{} as any,
createMockLogger(),
);
const result = await manager.getCodeQlPathWithoutVersionCheck();
expect(result).toBe(pathToCmd);
// no warning or error message
expect(warnSpy).toHaveBeenCalledTimes(0);
expect(errorSpy).toHaveBeenCalledTimes(0);
});
it("should warn when deprecated launcher is used, and new launcher is available", async () => {
await writeFile(pathToCmd, "");
await writeFile(pathToExe, "");
const manager = new DistributionManager(
{ customCodeQlPath: pathToCmd } as any,
{} as any,
{} as any,
createMockLogger(),
);
const result = await manager.getCodeQlPathWithoutVersionCheck();
expect(result).toBe(pathToCmd);
// has warning message
expect(warnSpy).toHaveBeenCalledTimes(1);
expect(errorSpy).toHaveBeenCalledTimes(0);
});
it("should warn when launcher path is incorrect", async () => {
const manager = new DistributionManager(
{ customCodeQlPath: pathToCmd } as any,
{} as any,
{} as any,
createMockLogger(),
);
const result = await manager.getCodeQlPathWithoutVersionCheck();
expect(result).toBeUndefined();
// no error message
expect(warnSpy).toHaveBeenCalledTimes(0);
expect(errorSpy).toHaveBeenCalledTimes(1);
});
});