[Repo Assist] refactor(strutil): move formatResetAt to strutil.FormatResetAt (#5042)

🤖 *This PR was created by Repo Assist, an automated AI assistant.*

Closes #5032 (Finding 4).

## Summary

`formatResetAt` in `server/circuit_breaker.go` is a pure time-formatting
utility that already delegates to `strutil.FormatDuration` for its
relative portion. Moving it to `internal/strutil/` keeps all
time-formatting utilities in one place, improves discoverability, and
removes an unexported utility function from a domain-specific file.

## Changes

- Add `FormatResetAt(t time.Time) string` to
`internal/strutil/format_duration.go`
- Add `TestFormatResetAt` with zero-time and non-zero-time cases
- Replace the four `formatResetAt(...)` call sites in
`circuit_breaker.go` with `strutil.FormatResetAt(...)`
- Remove the private `formatResetAt` function from `circuit_breaker.go`

## Test Status

Two new tests added in `internal/strutil/format_duration_test.go` cover
the zero-time and non-zero-time cases.

⚠️ **Infrastructure note**: `go test ./...` could not be executed in
this environment because `proxy.golang.org` is blocked and the module
cache is incomplete. The code changes are minimal and mechanically
correct.




> [!WARNING]
> **⚠️ Firewall blocked 1 domain**
>
> The following domain was blocked by the firewall during workflow
execution:
>
> - `proxy.golang.org`
>
> To allow these domains, add them to the `network.allowed` list in your
workflow frontmatter:
>
> ```yaml
> network:
>   allowed:
>     - defaults
>     - "proxy.golang.org"
> ```
>
> See [Network
Configuration](https://github.github.com/gh-aw/reference/network/) for
more information.


> Generated by [Repo
Assist](https://github.com/github/gh-aw-mcpg/actions/runs/25279282660/agentic_workflow)
· ● 6.9M ·
[◷](https://github.com/search?q=repo%3Agithub%2Fgh-aw-mcpg+%22gh-aw-workflow-id%3A+repo-assist%22&type=pullrequests)
>
> To install this [agentic
workflow](https://github.com/githubnext/agentics/blob/851905c06e905bf362a9f6cc54f912e3df747d55/workflows/repo-assist.md),
run
> ```
> gh aw add
githubnext/agentics@851905c
> ```

<!-- gh-aw-agentic-workflow: Repo Assist, engine: copilot, version:
1.0.21, model: auto, id: 25279282660, workflow_id: repo-assist, run:
https://github.com/github/gh-aw-mcpg/actions/runs/25279282660 -->

<!-- gh-aw-workflow-id: repo-assist -->

Author: lpcox

internal/server/circuit_breaker.go

@@ -195,12 +195,12 @@ func (cb *circuitBreaker) RecordRateLimit(resetAt time.Time) {
 			cb.openedAt = cb.nowFunc()
 			logger.LogError("backend",
 				"circuit breaker for server %q OPENED after %d consecutive rate-limit errors; resets at %s",
-				cb.serverID, cb.consecutiveErrors, formatResetAt(cb.resetAt))
+				cb.serverID, cb.consecutiveErrors, strutil.FormatResetAt(cb.resetAt))
 			logCircuitBreaker.Printf("server %q circuit breaker CLOSED → OPEN (errors=%d)", cb.serverID, cb.consecutiveErrors)
 		} else {
 			logger.LogWarn("backend",
 				"rate-limit error for server %q (consecutive=%d/%d); resets at %s",
-				cb.serverID, cb.consecutiveErrors, cb.threshold, formatResetAt(cb.resetAt))
+				cb.serverID, cb.consecutiveErrors, cb.threshold, strutil.FormatResetAt(cb.resetAt))
 		}
 
 	case circuitHalfOpen:
@@ -209,13 +209,13 @@ func (cb *circuitBreaker) RecordRateLimit(resetAt time.Time) {
 		cb.openedAt = cb.nowFunc()
 		logger.LogError("backend",
 			"circuit breaker for server %q re-OPENED after probe was rate-limited; resets at %s",
-			cb.serverID, formatResetAt(cb.resetAt))
+			cb.serverID, strutil.FormatResetAt(cb.resetAt))
 		logCircuitBreaker.Printf("server %q circuit breaker HALF-OPEN → OPEN (probe rate-limited)", cb.serverID)
 
 	case circuitOpen:
 		// Already open — update reset time.
 		logger.LogWarn("backend", "server %q circuit breaker still OPEN; resets at %s",
-			cb.serverID, formatResetAt(cb.resetAt))
+			cb.serverID, strutil.FormatResetAt(cb.resetAt))
 	}
 }
 
@@ -226,13 +226,6 @@ func (cb *circuitBreaker) State() circuitBreakerState {
 	return cb.state
 }
 
-// formatResetAt returns a human-readable representation of a reset time.
-func formatResetAt(t time.Time) string {
-	if t.IsZero() {
-		return "unknown"
-	}
-	return fmt.Sprintf("%s (in %s)", t.UTC().Format(time.RFC3339), strutil.FormatDuration(time.Until(t).Round(time.Second)))
-}
 
 // buildCircuitBreakers creates per-backend circuit breakers from the configuration.
 func buildCircuitBreakers(cfg *config.Config) map[string]*circuitBreaker {

internal/server/circuit_breaker_test.go

@@ -443,23 +443,6 @@ func TestCircuitBreakerState_String(t *testing.T) {
 	}
 }
 
-// TestFormatResetAt verifies the formatResetAt helper function.
-func TestFormatResetAt(t *testing.T) {
-	t.Parallel()
-
-	t.Run("zero time returns 'unknown'", func(t *testing.T) {
-		t.Parallel()
-		assert.Equal(t, "unknown", formatResetAt(time.Time{}))
-	})
-
-	t.Run("non-zero time includes RFC3339 timestamp and duration hint", func(t *testing.T) {
-		t.Parallel()
-		resetTime := time.Date(2026, 1, 1, 12, 0, 0, 0, time.UTC)
-		result := formatResetAt(resetTime)
-		assert.Contains(t, result, "2026-01-01T12:00:00Z", "should contain RFC3339-formatted time")
-		assert.Contains(t, result, "in ", "should contain duration hint")
-	})
-}
 
 // TestIsRateLimitText_Direct directly verifies isRateLimitText with each pattern and edge cases.
 func TestIsRateLimitText_Direct(t *testing.T) {

internal/strutil/format_duration.go

@@ -5,6 +5,16 @@ import (
 	"time"
 )
 
+// FormatResetAt returns a human-readable representation of a reset time,
+// combining an RFC3339 timestamp with a relative countdown (e.g. "2026-05-03T12:00:00Z (in 5.0m)").
+// Returns "unknown" when t is the zero value.
+func FormatResetAt(t time.Time) string {
+	if t.IsZero() {
+		return "unknown"
+	}
+	return fmt.Sprintf("%s (in %s)", t.UTC().Format(time.RFC3339), FormatDuration(time.Until(t).Round(time.Second)))
+}
+
 // FormatDuration formats a duration for display like the debug npm package.
 // It provides granular formatting from nanoseconds to hours.
 func FormatDuration(d time.Duration) string {

internal/strutil/format_duration_test.go

@@ -164,3 +164,18 @@ func TestFormatDuration(t *testing.T) {
 		})
 	}
 }
+
+func TestFormatResetAt(t *testing.T) {
+t.Run("zero time returns unknown", func(t *testing.T) {
+result := FormatResetAt(time.Time{})
+assert.Equal(t, "unknown", result)
+})
+
+t.Run("non-zero time includes RFC3339 timestamp and relative countdown", func(t *testing.T) {
+// Use a fixed future time so the test is deterministic.
+future := time.Date(2030, 1, 1, 12, 0, 0, 0, time.UTC)
+result := FormatResetAt(future)
+assert.Contains(t, result, "2030-01-01T12:00:00Z")
+assert.Contains(t, result, " (in ")
+})
+}