Fix webhook "Properties of" dropdowns rendering empty (#61008)

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Author: Ebonsignori

src/webhooks/lib/index.ts

@@ -77,17 +77,22 @@ export async function getInitialPageWebhooks(version: string): Promise<InitialWe
       data: defaultAction ? webhook[defaultAction] : {},
     }
 
-    // remove all nested params for the initial webhooks page, we'll load
-    // them by request
+    // Remove all nested params for the initial webhooks page — we'll load
+    // them on demand via the /api/webhooks/v1 endpoint. Shallow-clone the
+    // data object and each body parameter first so we don't mutate the
+    // objects cached by getWebhooks(), which would cause the lazy-loaded
+    // fetch to return empty childParamsGroups.
     if (initialWebhook.data.bodyParameters) {
-      for (const bodyParam of initialWebhook.data.bodyParameters) {
-        if (bodyParam.childParamsGroups) {
-          bodyParam.childParamsGroups = []
-        }
+      initialWebhook.data = {
+        ...initialWebhook.data,
+        bodyParameters: initialWebhook.data.bodyParameters.map((bodyParam) => ({
+          ...bodyParam,
+          ...(bodyParam.childParamsGroups ? { childParamsGroups: [] } : {}),
+        })),
       }
     }
 
-    initialWebhooks.push({ ...initialWebhook })
+    initialWebhooks.push(initialWebhook)
   }
   initialWebhooksCache.set(version, initialWebhooks)
   return initialWebhooks

src/webhooks/lib/tests/index.ts

@@ -0,0 +1,59 @@
+import { describe, expect, it } from 'vitest'
+
+import { getInitialPageWebhooks, getWebhook } from '../index'
+
+// Use a version that's guaranteed to exist in the data directory.
+const VERSION = 'free-pro-team@latest'
+
+// Pick a webhook category whose data file has body parameters with
+// non-empty childParamsGroups so we can verify they survive the
+// initial-page stripping.
+const CATEGORY = 'projects_v2_item'
+
+describe('getInitialPageWebhooks does not corrupt the getWebhook cache', () => {
+  it('strips childParamsGroups from the initial-page data', async () => {
+    const initial = await getInitialPageWebhooks(VERSION)
+    const initialWebhook = initial.find((w) => w.name === CATEGORY)
+    expect(initialWebhook).toBeDefined()
+
+    for (const bp of initialWebhook!.data.bodyParameters ?? []) {
+      if (bp.childParamsGroups) {
+        expect(bp.childParamsGroups, `initial ${bp.name} should be stripped`).toHaveLength(0)
+      }
+    }
+  })
+
+  it('preserves childParamsGroups in the getWebhook cache after getInitialPageWebhooks runs', async () => {
+    // Seed the cache and record original childParamsGroups lengths.
+    const before = await getWebhook(VERSION, CATEGORY)
+    expect(before).toBeDefined()
+
+    const originalLengths: Record<string, number> = {}
+    for (const [action, actionData] of Object.entries(before!)) {
+      for (const bp of actionData.bodyParameters ?? []) {
+        if (bp.childParamsGroups && bp.childParamsGroups.length > 0) {
+          originalLengths[`${action}.${bp.name}`] = bp.childParamsGroups.length
+        }
+      }
+    }
+    expect(Object.keys(originalLengths).length).toBeGreaterThan(0)
+
+    // This intentionally empties childParamsGroups for the initial page render.
+    await getInitialPageWebhooks(VERSION)
+
+    // getWebhook returns cached data — it must NOT have been mutated.
+    const after = await getWebhook(VERSION, CATEGORY)
+    expect(after).toBeDefined()
+
+    for (const [key, expectedLen] of Object.entries(originalLengths)) {
+      const [action, paramName] = key.split('.')
+      const bp = after![action]?.bodyParameters?.find(
+        (p: { name?: string }) => p.name === paramName,
+      )
+      expect(
+        bp?.childParamsGroups?.length,
+        `${key}.childParamsGroups should still have ${expectedLen} entries`,
+      ).toBe(expectedLen)
+    }
+  })
+})