Merge branch 'main' into copilot/review-code-changes

Author: patniko

.github/dependabot.yaml

@@ -1,34 +1,31 @@
 version: 2
+multi-ecosystem-groups:
+  all:
+    schedule:
+      interval: 'weekly'
 updates:
   - package-ecosystem: 'github-actions'
     directory: '/'
-    schedule:
-      interval: 'weekly'
+    multi-ecosystem-group: 'all'
   - package-ecosystem: 'devcontainers'
     directory: '/'
-    schedule:
-      interval: 'weekly'
+    multi-ecosystem-group: 'all'
   # Node.js dependencies
   - package-ecosystem: 'npm'
     directory: '/nodejs'
-    schedule:
-      interval: 'weekly'
+    multi-ecosystem-group: 'all'
   - package-ecosystem: 'npm'
     directory: '/test/harness'
-    schedule:
-      interval: 'weekly'
+    multi-ecosystem-group: 'all'
   # Python dependencies
   - package-ecosystem: 'pip'
     directory: '/python'
-    schedule:
-      interval: 'weekly'
+    multi-ecosystem-group: 'all'
   # Go dependencies
   - package-ecosystem: 'gomod'
     directory: '/go'
-    schedule:
-      interval: 'weekly'
+    multi-ecosystem-group: 'all'
   # .NET dependencies
   - package-ecosystem: 'nuget'
     directory: '/dotnet'
-    schedule:
-      interval: 'weekly'
+    multi-ecosystem-group: 'all'

dotnet/test/GitHub.Copilot.SDK.Test.csproj

@@ -19,7 +19,7 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="18.0.1" />
+    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="18.3.0" />
     <PackageReference Include="xunit" Version="2.9.3" />
     <PackageReference Include="xunit.runner.visualstudio" Version="3.1.5">
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>

go/README.md

@@ -25,6 +25,7 @@ go run chat.go
 package main
 
 import (
+	"context"
     "fmt"
     "log"
 
@@ -285,6 +286,7 @@ Enable streaming to receive assistant response chunks as they're generated:
 package main
 
 import (
+	"context"
     "fmt"
     "log"
 

python/copilot/client.py

@@ -1595,7 +1595,7 @@ async def _execute_tool_call(
                 toolTelemetry={},
             )
 
-        return self._normalize_tool_result(result)
+        return self._normalize_tool_result(cast(ToolResult, result))
 
     def _normalize_tool_result(self, result: ToolResult) -> ToolResult:
         """

python/copilot/jsonrpc.py

@@ -104,22 +104,23 @@ async def stop(self):
             self._stderr_thread.join(timeout=1.0)
 
     async def request(
-        self, method: str, params: Optional[dict] = None, timeout: float = 30.0
+        self, method: str, params: Optional[dict] = None, timeout: Optional[float] = None
     ) -> Any:
         """
         Send a JSON-RPC request and wait for response
 
         Args:
             method: Method name
             params: Optional parameters
-            timeout: Request timeout in seconds (default 30s)
+            timeout: Optional request timeout in seconds. If None (default),
+                waits indefinitely for the server to respond.
 
         Returns:
             The result from the response
 
         Raises:
             JsonRpcError: If server returns an error
-            asyncio.TimeoutError: If request times out
+            asyncio.TimeoutError: If request times out (only when timeout is set)
         """
         request_id = str(uuid.uuid4())
 
@@ -141,7 +142,9 @@ async def request(
         await self._send_message(message)
 
         try:
-            return await asyncio.wait_for(future, timeout=timeout)
+            if timeout is not None:
+                return await asyncio.wait_for(future, timeout=timeout)
+            return await future
         finally:
             with self._pending_lock:
                 self.pending_requests.pop(request_id, None)

python/copilot/session.py

@@ -8,7 +8,7 @@
 import asyncio
 import inspect
 import threading
-from typing import Any, Callable, Optional
+from typing import Any, Callable, Optional, cast
 
 from .generated.rpc import SessionRpc
 from .generated.session_events import SessionEvent, SessionEventType, session_event_from_dict
@@ -336,7 +336,7 @@ async def _handle_permission_request(
             result = handler(request, {"session_id": self.session_id})
             if inspect.isawaitable(result):
                 result = await result
-            return result
+            return cast(PermissionRequestResult, result)
         except Exception:  # pylint: disable=broad-except
             # Handler failed, deny permission
             return {"kind": "denied-no-approval-rule-and-could-not-request-from-user"}
@@ -388,7 +388,7 @@ async def _handle_user_input_request(self, request: dict) -> UserInputResponse:
             )
             if inspect.isawaitable(result):
                 result = await result
-            return result
+            return cast(UserInputResponse, result)
         except Exception:
             raise