Skip CLI npm ci when tests are skipped

Address review comment on PR #137 (discussion_r3165129538): the
install-nodejs-cli-dependencies execution previously ran on every
invocation of generate-test-resources because it was only guarded by
${skip.test.harness}. That made non-test builds (e.g. mvn package
-DskipTests, mvn deploy -Dmaven.test.skip=true) require npm and
network access unnecessarily.

Introduce a new ${skip.cli.install} property that defaults to
${skip.test.harness} but is forced to true when -DskipTests=true or
-Dmaven.test.skip=true is set, via two auto-activated profiles. Wire
the install-nodejs-cli-dependencies execution's <skip> to this new
property.

Author: edburns

pom.xml

@@ -62,6 +62,17 @@
         <copilot.cli.path>${copilot.sdk.clone.dir}/nodejs/node_modules/@github/copilot/index.js</copilot.cli.path>
         <!-- Set to true (via -Pskip-test-harness) to skip git-clone + npm install of test harness -->
         <skip.test.harness>false</skip.test.harness>
+        <!--
+            Whether to skip the install-nodejs-cli-dependencies execution
+            (npm ci of the @github/copilot CLI). Defaults to ${skip.test.harness}
+            so it tracks the rest of the test-harness setup, but is also
+            forced to true when Maven tests are skipped (-DskipTests or
+            -Dmaven.test.skip) via the skip-cli-install-when-tests-skipped
+            and skip-cli-install-when-maven-test-skip profiles below, so that
+            non-test builds (e.g. package/deploy with tests skipped) do not
+            require npm or network access.
+        -->
+        <skip.cli.install>${skip.test.harness}</skip.cli.install>
         <!-- Extra JVM args for Surefire; overridden by the jdk21+ profile -->
         <surefire.jvm.args />
         <!--
@@ -292,7 +303,7 @@
                             <goal>exec</goal>
                         </goals>
                         <configuration>
-                            <skip>${skip.test.harness}</skip>
+                            <skip>${skip.cli.install}</skip>
                             <executable>npm</executable>
                             <workingDirectory>${copilot.sdk.clone.dir}/nodejs</workingDirectory>
                             <arguments>
@@ -657,6 +668,39 @@
                 <skip.test.harness>true</skip.test.harness>
             </properties>
         </profile>
+        <!--
+            Skip the install-nodejs-cli-dependencies (npm ci) execution when
+            tests are skipped via -DskipTests, so non-test builds do not
+            require npm or network access. Activates automatically; no manual
+            -P needed.
+        -->
+        <profile>
+            <id>skip-cli-install-when-tests-skipped</id>
+            <activation>
+                <property>
+                    <name>skipTests</name>
+                    <value>true</value>
+                </property>
+            </activation>
+            <properties>
+                <skip.cli.install>true</skip.cli.install>
+            </properties>
+        </profile>
+        <!--
+            Same as above, but for -Dmaven.test.skip=true.
+        -->
+        <profile>
+            <id>skip-cli-install-when-maven-test-skip</id>
+            <activation>
+                <property>
+                    <name>maven.test.skip</name>
+                    <value>true</value>
+                </property>
+            </activation>
+            <properties>
+                <skip.cli.install>true</skip.cli.install>
+            </properties>
+        </profile>
         <!-- Debug profile for FINE logging during tests -->
         <profile>
             <id>debug</id>