Skip to content

Commit 478d829

Browse files
Copilotedburns
andauthored
Address review: fix commit message, remove --save-exact, fix WORKFLOWS.md links and add codegen-only note
Agent-Logs-Url: https://github.com/github/copilot-sdk-java/sessions/d68264a5-52bb-497f-bca0-5ef13a7efdec Co-authored-by: edburns <75821+edburns@users.noreply.github.com>
1 parent 47e6ed4 commit 478d829

3 files changed

Lines changed: 8 additions & 4 deletions

File tree

.github/scripts/reference-impl-sync/merge-reference-impl-finish.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ echo "▸ Syncing @github/copilot version in scripts/codegen/package.json…"
6767
"$ROOT_DIR/.github/scripts/reference-impl-sync/sync-codegen-version.sh" "$REFERENCE_IMPL_DIR"
6868

6969
git add .lastmerge pom.xml scripts/codegen/package.json scripts/codegen/package-lock.json
70-
git commit -m "Update .lastmerge to $NEW_COMMIT and sync pom.xml CLI version"
70+
git commit -m "Update .lastmerge to $NEW_COMMIT, sync pom.xml CLI version, and update scripts/codegen @github/copilot version"
7171

7272
# ── 3. Push branch ───────────────────────────────────────────
7373
echo "▸ Pushing branch $BRANCH_NAME to origin…"

.github/scripts/reference-impl-sync/sync-codegen-version.sh

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,9 @@ if [[ ! -f "$CODEGEN_PKG" ]]; then
6363
fi
6464

6565
# Update scripts/codegen/package.json with the new version and regenerate the lock file.
66+
# Intentionally omit --save-exact to preserve the version specifier used by the reference
67+
# implementation (e.g. a caret range like '^1.0.36-0' rather than an exact pin '1.0.36-0').
6668
echo "▸ Updating scripts/codegen/package.json: @github/copilot → ${CLI_VERSION}"
6769
cd "$CODEGEN_DIR"
68-
npm install "@github/copilot@${CLI_VERSION}" --save-exact
70+
npm install "@github/copilot@${CLI_VERSION}"
6971
echo "▸ Updated scripts/codegen to @github/copilot@${CLI_VERSION}"

docs/WORKFLOWS.md

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,11 @@
66
|----------|-------------|----------|----------|
77
| [Build & Test](workflows/build-test.yml) | Builds, lints, and tests the Java SDK | `push` (main), `pull_request`, `merge_group`, `workflow_dispatch` | Sundays at 00:00 UTC |
88
| [Codegen Check](workflows/codegen-check.yml) | Verifies that generated Java files are up-to-date with the JSON schemas | `push` (main), `pull_request`, `workflow_dispatch` ||
9-
| [Update @github/copilot Dependency](workflows/update-copilot-dependency.yml) | Updates the `@github/copilot` npm package, re-runs code generation, and opens a PR | `workflow_dispatch` ||
9+
| [Update @github/copilot Dependency](workflows/update-copilot-dependency.yml) | _(Codegen-only)_ Updates the `@github/copilot` npm package in `scripts/codegen`, re-runs code generation, and opens a PR. Does **not** update `pom.xml`; use the Reference Implementation Sync for full version alignment. | `workflow_dispatch` ||
1010
| [Deploy Documentation](workflows/deploy-site.yml) | Generates and deploys versioned docs to GitHub Pages | `workflow_run` (after Build & Test), `release`, `workflow_dispatch` ||
1111
| [Publish to Maven Central](workflows/publish-maven.yml) | Releases the SDK to Maven Central and creates a GitHub Release | `workflow_dispatch` ||
1212
| [Reference Implementation Sync](workflows/reference-impl-sync.yml) | Checks for new reference implementation commits and creates an issue for Copilot to merge | `workflow_dispatch` | [See workflow](workflows/reference-impl-sync.yml) |
13-
| [Reference Implementation Sync (Agentic)](workflows/reference-impl-sync.lock.yml) | Compiled agentic workflow that executes the reference implementation sync via `gh-aw` | `workflow_dispatch` | [See workflow](workflows/reference-impl-sync.yml) |
13+
| [Reference Implementation Sync (Agentic)](workflows/reference-impl-sync.lock.yml) | Compiled agentic workflow that executes the reference implementation sync via `gh-aw` | `workflow_dispatch` | [See workflow](workflows/reference-impl-sync.lock.yml) |
1414
| [Copilot Setup Steps](workflows/copilot-setup-steps.yml) | Configures the environment for the GitHub Copilot coding agent | `push` (on self-change), `workflow_dispatch` ||
1515

1616
---
@@ -113,6 +113,8 @@ If changes appear, commit the updated generated files.
113113

114114
**File:** [`update-copilot-dependency.yml`](workflows/update-copilot-dependency.yml)
115115

116+
> **Note:** This workflow is for codegen-only updates to `scripts/codegen`. It does **not** update `pom.xml`. For full version alignment (both CLI and codegen in lockstep), use the **Reference Implementation Sync** workflow instead.
117+
116118
Manual workflow triggered when a new version of the `@github/copilot` npm package is published. Accepts a `version` input (e.g. `1.0.25`).
117119

118120
Steps:

0 commit comments

Comments
 (0)