Skip to content

Commit e466e75

Browse files
Simplify doesGoExtractionOutputExist implementation
Co-authored-by: Andrew Eisenberg <aeisenberg@github.com>
1 parent fff56ee commit e466e75

3 files changed

Lines changed: 11 additions & 19 deletions

File tree

lib/analyze-action.js

Lines changed: 2 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/analyze-action.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/analyze-action.ts

Lines changed: 8 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -32,12 +32,12 @@ const pkg = require("../package.json");
3232

3333
interface AnalysisStatusReport
3434
extends upload_lib.UploadStatusReport,
35-
QueriesStatusReport {}
35+
QueriesStatusReport { }
3636

3737
interface FinishStatusReport
3838
extends actionsUtil.StatusReportBase,
39-
actionsUtil.DatabaseCreationTimings,
40-
AnalysisStatusReport {}
39+
actionsUtil.DatabaseCreationTimings,
40+
AnalysisStatusReport { }
4141

4242
interface FinishWithTrapUploadStatusReport extends FinishStatusReport {
4343
/** Size of TRAP caches that we uploaded, in bytes. */
@@ -71,9 +71,9 @@ export async function sendStatusReport(
7171
...statusReportBase,
7272
...(config
7373
? {
74-
ml_powered_javascript_queries:
75-
util.getMlPoweredJsQueriesStatus(config),
76-
}
74+
ml_powered_javascript_queries:
75+
util.getMlPoweredJsQueriesStatus(config),
76+
}
7777
: {}),
7878
...(stats || {}),
7979
...(dbCreationTimings || {}),
@@ -106,15 +106,11 @@ function hasBadExpectErrorInput(): boolean {
106106
*/
107107
function doesGoExtractionOutputExist(config: Config): boolean {
108108
const golangDbDirectory = util.getCodeQLDatabasePath(config, Language.go);
109-
const extractedFiles = fs
109+
return fs
110110
.readdirSync(golangDbDirectory)
111-
.filter(
111+
.some(
112112
(fileName) => fileName.endsWith(".trap") || fileName.endsWith(".trap.gz")
113113
);
114-
if (extractedFiles.length !== 0) {
115-
return true;
116-
}
117-
return false;
118114
}
119115

120116
async function run() {

0 commit comments

Comments
 (0)