Skip to content

Commit a9055f2

Browse files
committed
Address PR comment & check for rule.id
1 parent 5156052 commit a9055f2

5 files changed

Lines changed: 11 additions & 17 deletions

File tree

lib/analyze.js

Lines changed: 3 additions & 8 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/analyze.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/util.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/analyze.ts

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -434,13 +434,9 @@ export async function runQueries(
434434
for (const sarifRun of sarifObject.runs) {
435435
if (sarifRun.results) {
436436
for (const result of sarifRun.results) {
437-
if (result.ruleId) {
438-
if (result.ruleId in perQueryAlertCounts) {
439-
perQueryAlertCounts[result.ruleId] =
440-
perQueryAlertCounts[result.ruleId] + 1;
441-
} else {
442-
perQueryAlertCounts[result.ruleId] = 1;
443-
}
437+
const query = result.rule?.id || result.ruleId;
438+
if (query) {
439+
perQueryAlertCounts[query] = (perQueryAlertCounts[query] || 0) + 1;
444440
}
445441
}
446442
}

src/util.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,9 @@ export interface SarifInvocation {
7272

7373
export interface SarifResult {
7474
ruleId?: string;
75+
rule?: {
76+
id?: string;
77+
};
7578
message?: {
7679
text?: string;
7780
};

0 commit comments

Comments
 (0)