Refactors output handling

Author: rvlb

lib/index.js

@@ -49,18 +49,14 @@ class BundleTrackerPlugin {
     /** @type {Options} */
     this.options = options;
     /** @type {Contents} */
-    this.contents = {
+    this.output = {
       status: 'initialization',
       assets: {},
       chunks: {},
     };
     this.name = 'BundleTrackerPlugin';
 
-    this.output = {
-      status: 'compile',
-      assets: {},
-      chunks: {},
-    };
+    this.assets = {};
     this.outputChunkDir = '';
     this.outputTrackerFile = '';
     this.outputTrackerDir = '';
@@ -109,19 +105,18 @@ class BundleTrackerPlugin {
   /**
    * Write bundle tracker stats file
    */
-  _writeOutput() {
-    const contents = this.output;
-    Object.assign(this.contents, contents, {
-      assets: mergeObjectsAndSortKeys(this.contents.assets, contents.assets),
-      chunks: mergeObjectsAndSortKeys(this.contents.chunks, contents.chunks),
+  _writeOutput(contents) {
+    Object.assign(this.output, contents, {
+      assets: mergeObjectsAndSortKeys(this.output.assets, contents.assets),
+      chunks: mergeObjectsAndSortKeys(this.output.chunks, contents.chunks),
     });
 
     if (this.options.publicPath) {
-      this.contents.publicPath = this.options.publicPath;
+      this.output.publicPath = this.options.publicPath;
     }
 
     fs.mkdirSync(this.outputTrackerDir, { recursive: true, mode: 0o755 });
-    fs.writeFileSync(this.outputTrackerFile, JSON.stringify(this.contents, null, this.options.indent));
+    fs.writeFileSync(this.outputTrackerFile, JSON.stringify(this.output, null, this.options.indent));
   }
   /**
    * Compute hash for a content
@@ -145,8 +140,7 @@ class BundleTrackerPlugin {
    * Handle compile hook
    */
   _handleCompile() {
-    this.output = { status: 'compile', assets: {}, chunks: {} };
-    this._writeOutput();
+    this._writeOutput({ status: 'compile' });
   }
 
   /**
@@ -188,7 +182,7 @@ class BundleTrackerPlugin {
       fileInfo.sourceFilename = this._compilation.assetsInfo.get(assetName).sourceFilename;
     }
 
-    this.output.assets[assetName] = fileInfo;
+    this.assets[assetName] = fileInfo;
   }
 
   /**
@@ -204,28 +198,26 @@ class BundleTrackerPlugin {
         return compilation.children.find(child => findError(child));
       };
       const error = findError(stats.compilation);
-      // @ts-ignore: TS2739
-      this.output = {
+      this._writeOutput({
         status: 'error',
         error: error?.name ?? 'unknown-error',
         message: stripAnsi(error['message']),
-      };
-      this._writeOutput();
-
+      });
       return;
     }
 
+    const chunks = {};
     stats.compilation.chunkGroups.forEach(chunkGroup => {
       if (!chunkGroup.isInitial()) return;
-      this.output.chunks[chunkGroup.name] = chunkGroup.getFiles();
+      chunks[chunkGroup.name] = chunkGroup.getFiles();
     });
 
+    const output = { status: 'done', chunks, assets: this.assets };
     if (this.options.logTime === true) {
-      this.output.startTime = stats.startTime;
-      this.output.endTime = stats.endTime;
+      output.startTime = stats.startTime;
+      output.endTime = stats.endTime;
     }
-    this.output.status = 'done';
-    this._writeOutput();
+    this._writeOutput(output);
   }
 
   /**