Only pass profile-correction flag on GCC

Copybara Import from #580
cloned from unknown commit to add BtrGuardian exclusion

BEGIN_PUBLIC
Only pass profile-correction flag on GCC (#580)

This is a GCC flag, Clang emits a warning and ignores it.

Closes #580
END_PUBLIC

COPYBARA_INTEGRATE_REVIEW=#580 from dzbarsky:zbarsky/profile-correction 7970c98
PiperOrigin-RevId: 871744266
Change-Id: I7b3664d7f6f0673327cf4be05b11d28ec1b9a9dc

Author: dzbarsky

cc/cc_toolchain_config_lib.bzl

@@ -614,3 +614,9 @@ def artifact_name_pattern(category_name, prefix, extension):
         extension = extension,
         type_name = "artifact_name_pattern",
     )
+
+def _is_gcc_compiler(compiler):
+    return "gcc" in compiler
+
+def get_profile_correction_flags(ctx):
+    return ["-fprofile-correction"] if hasattr(ctx.attr, "compiler") and _is_gcc_compiler(ctx.attr.compiler) else []

cc/private/toolchain/unix_cc_toolchain_config.bzl

@@ -24,6 +24,7 @@ load(
     "feature_set",
     "flag_group",
     "flag_set",
+    "get_profile_correction_flags",
     "tool",
     "tool_path",
     "variable_with_value",
@@ -237,6 +238,7 @@ def _sanitizer_feature(name = "", specific_compile_flags = [], specific_link_fla
 
 def _impl(ctx):
     is_linux = ctx.attr.target_libc != "macosx"
+    profile_correction_flags = get_profile_correction_flags(ctx)
 
     tool_paths = [
         tool_path(name = name, path = path)
@@ -623,8 +625,7 @@ def _impl(ctx):
                     flag_group(
                         flags = [
                             "-fprofile-use=%{fdo_profile_path}",
-                            "-fprofile-correction",
-                        ],
+                        ] + profile_correction_flags,
                         expand_if_available = "fdo_profile_path",
                     ),
                 ],
@@ -786,8 +787,7 @@ def _impl(ctx):
                             "-fprofile-use=%{fdo_profile_path}",
                             "-Wno-profile-instr-unprofiled",
                             "-Wno-profile-instr-out-of-date",
-                            "-fprofile-correction",
-                        ],
+                        ] + profile_correction_flags,
                         expand_if_available = "fdo_profile_path",
                     ),
                 ],
@@ -805,8 +805,7 @@ def _impl(ctx):
                     flag_group(
                         flags = [
                             "-fauto-profile=%{fdo_profile_path}",
-                            "-fprofile-correction",
-                        ],
+                        ] + profile_correction_flags,
                         expand_if_available = "fdo_profile_path",
                     ),
                 ],

cc/private/toolchain/windows_cc_toolchain_config.bzl

@@ -23,6 +23,7 @@ load(
     "feature",
     "flag_group",
     "flag_set",
+    "get_profile_correction_flags",
     "make_variable",
     "tool",
     "tool_path",
@@ -100,6 +101,8 @@ def _use_msvc_toolchain(ctx):
     return ctx.attr.cpu in ["x64_windows", "arm64_windows"] and (ctx.attr.compiler == "msvc-cl" or ctx.attr.compiler == "clang-cl")
 
 def _impl(ctx):
+    profile_correction_flags = get_profile_correction_flags(ctx)
+
     if _use_msvc_toolchain(ctx):
         artifact_name_patterns = [
             artifact_name_pattern(
@@ -1551,8 +1554,7 @@ def _impl(ctx):
                             flag_group(
                                 flags = [
                                     "-fprofile-use=%{fdo_profile_path}",
-                                    "-fprofile-correction",
-                                ],
+                                ] + profile_correction_flags,
                                 expand_if_available = "fdo_profile_path",
                             ),
                         ],

cc/private/toolchain_config/cc_toolchain_config_info.bzl

@@ -102,7 +102,12 @@ def create_cc_toolchain_config_info(
             default_compile_flags = ([f for f in features if f.name == "default_compile_flags"])[0]
             legacy_features.append(default_compile_flags)
         platform = "mac" if target_libc == "macosx" else "linux"
-        legacy_features.extend(get_legacy_features(platform, feature_names, linker_tool_path))
+        legacy_features.extend(get_legacy_features(
+            ctx,
+            platform,
+            feature_names,
+            linker_tool_path,
+        ))
         legacy_features.extend([f for f in features if f.name not in ["legacy_compile_flags", "default_compile_flags"]])
         legacy_features.extend(get_features_to_appear_last(feature_names))
 

cc/private/toolchain_config/legacy_features.bzl

@@ -21,26 +21,29 @@ load(
     "feature_set",
     "flag_group",
     "flag_set",
+    "get_profile_correction_flags",
     "tool",
     "variable_with_value",
     "with_feature_set",
 )
 
-def get_legacy_features(platform, existing_feature_names, linker_tool_path):
+def get_legacy_features(ctx, platform, existing_feature_names, linker_tool_path):
     """The features added to all legacy toolchains
 
     Note: these features won't be added to the crosstools that defines
     no_legacy_features feature (e.g. ndk, apple, enclave crosstools). Those need
     to be modified separately.
 
     Args:
+        ctx: bazel rule context
         platform: (str) One of 'linux' or 'mac'
         existing_feature_names: ([str])
         linker_tool_path: (str)
 
     Returns:
         ([FeatureInfo])
     """
+    profile_correction_flags = get_profile_correction_flags(ctx)
     result = []
     if "legacy_compile_flags" not in existing_feature_names:
         result.append(feature(
@@ -285,8 +288,7 @@ def get_legacy_features(platform, existing_feature_names, linker_tool_path):
                         "-fprofile-use=%{fdo_profile_path}",
                         "-Wno-profile-instr-unprofiled",
                         "-Wno-profile-instr-out-of-date",
-                        "-fprofile-correction",
-                    ],
+                    ] + profile_correction_flags,
                 )],
             )],
         ))
@@ -326,8 +328,7 @@ def get_legacy_features(platform, existing_feature_names, linker_tool_path):
                         "-fprofile-use=%{fdo_profile_path}",
                         "-Wno-profile-instr-unprofiled",
                         "-Wno-profile-instr-out-of-date",
-                        "-fprofile-correction",
-                    ],
+                    ] + profile_correction_flags,
                 )],
             )],
         ))
@@ -364,8 +365,7 @@ def get_legacy_features(platform, existing_feature_names, linker_tool_path):
                     expand_if_available = "fdo_profile_path",
                     flags = [
                         "-fauto-profile=%{fdo_profile_path}",
-                        "-fprofile-correction",
-                    ],
+                    ] + profile_correction_flags,
                 )],
             )],
         ))