[Confluence] Add get_all_spaces and switch Cloud space methods to v2 plural endpoint (#1638)

* [Confluence] Add get_all_spaces and switch Cloud space methods to v2 plural endpoint

Fixes #1560.

After commit 63e744f the legacy `get_all_spaces` was removed entirely from
the Cloud module — `Confluence("https://api.atlassian.com/ex/confluence/...")`
routes to the new `Cloud` class, which only has `get_spaces` (singular path).
Calling `c.get_all_spaces()` now raises AttributeError; users with OAuth/PAT
tokens routed through the API gateway lose the paginated enumeration they had
under the old v1 path.

Cloud's space methods also use the singular `space` path (e.g.
`self.get("space")`) while `api_root="wiki/api/v2"`, so the constructed URL
`/wiki/api/v2/space` doesn't match the documented v2 endpoint
`/wiki/api/v2/spaces` (plural — see
https://developer.atlassian.com/cloud/confluence/rest/v2/api-group-space/).

This change:
- Adds `Cloud.get_all_spaces()` returning a paginated generator over
  `_get_paged("spaces")`, restoring the back-compat surface and using v2.
- Switches `get_spaces`, `get_space`, `create_space`, `update_space`,
  `delete_space`, `get_space_content` from `space[/...]` to `spaces[/...]`.
- Updates the existing space mock-tests to assert the v2 plural path and
  adds a pagination test for `get_all_spaces`.

The Server implementation is unchanged (still uses v1 `space` paths
correctly, since Server is not affected by gateway routing).

Signed-off-by: 1fanwang <1fannnw@gmail.com>

* [Confluence] Fix multi-line docstrings in cloud space methods to D213 (summary on second line)

Signed-off-by: 1fanwang <1fannnw@gmail.com>

---------

Signed-off-by: 1fanwang <1fannnw@gmail.com>

Author: 1fanwang

atlassian/confluence/cloud/__init__.py

@@ -70,28 +70,45 @@ def get_content_ancestors(self, content_id, **kwargs):
 
     # Space Management
     def get_spaces(self, **kwargs):
-        """Get all spaces."""
-        return self.get("space", **kwargs)
+        """
+        Get all spaces (single page).
+
+        Calls the Confluence Cloud v2 endpoint ``/wiki/api/v2/spaces``.
+        For paginated enumeration of every space, use :meth:`get_all_spaces`.
+        """
+        return self.get("spaces", **kwargs)
+
+    def get_all_spaces(self, **kwargs):
+        """
+        Get all spaces with full pagination.
+
+        Returns a generator yielding each space dict from the Confluence Cloud
+        v2 endpoint ``/wiki/api/v2/spaces``. Replaces the legacy v1
+        ``get_all_spaces`` (which hit ``/rest/api/space``) — that endpoint is
+        not available on the OAuth API gateway and returns
+        ``GoneException: This deprecated endpoint has been removed``.
+        """
+        return self._get_paged("spaces", params=kwargs)
 
     def get_space(self, space_id, **kwargs):
         """Get space by ID."""
-        return self.get(f"space/{space_id}", **kwargs)
+        return self.get(f"spaces/{space_id}", **kwargs)
 
     def create_space(self, data, **kwargs):
         """Create new space."""
-        return self.post("space", data=data, **kwargs)
+        return self.post("spaces", data=data, **kwargs)
 
     def update_space(self, space_id, data, **kwargs):
         """Update existing space."""
-        return self.put(f"space/{space_id}", data=data, **kwargs)
+        return self.put(f"spaces/{space_id}", data=data, **kwargs)
 
     def delete_space(self, space_id, **kwargs):
         """Delete space."""
-        return self.delete(f"space/{space_id}", **kwargs)
+        return self.delete(f"spaces/{space_id}", **kwargs)
 
     def get_space_content(self, space_id, **kwargs):
         """Get space content."""
-        return self.get(f"space/{space_id}/content", **kwargs)
+        return self.get(f"spaces/{space_id}/content", **kwargs)
 
     # User Management
     def get_users(self, **kwargs):

tests/confluence/test_confluence_cloud.py

@@ -150,52 +150,72 @@ def test_get_content_ancestors(self, mock_get, confluence_cloud):
     # Space Management Tests
     @patch.object(ConfluenceCloud, "get")
     def test_get_spaces(self, mock_get, confluence_cloud):
-        """Test get_spaces method."""
+        """get_spaces calls the v2 plural endpoint /wiki/api/v2/spaces."""
         mock_get.return_value = {"results": [{"id": "TEST", "name": "Test Space"}]}
         result = confluence_cloud.get_spaces()
-        mock_get.assert_called_once_with("space", **{})
+        mock_get.assert_called_once_with("spaces", **{})
         assert result == {"results": [{"id": "TEST", "name": "Test Space"}]}
 
+    @patch.object(ConfluenceCloud, "get")
+    def test_get_all_spaces_paginates(self, mock_get, confluence_cloud):
+        """get_all_spaces yields every space across paginated v2 responses."""
+        mock_get.side_effect = [
+            {
+                "results": [{"id": "1", "name": "A"}, {"id": "2", "name": "B"}],
+                "_links": {"next": "/wiki/api/v2/spaces?cursor=NEXT"},
+            },
+            {"results": [{"id": "3", "name": "C"}], "_links": {}},
+        ]
+        result = list(confluence_cloud.get_all_spaces())
+        assert result == [
+            {"id": "1", "name": "A"},
+            {"id": "2", "name": "B"},
+            {"id": "3", "name": "C"},
+        ]
+        # Entry-point URL is the v2 plural path; pagination URL handling is
+        # covered by existing _get_paged tests.
+        assert mock_get.call_args_list[0].args[0] == "spaces"
+
     @patch.object(ConfluenceCloud, "get")
     def test_get_space(self, mock_get, confluence_cloud):
-        """Test get_space method."""
+        """get_space calls the v2 plural endpoint."""
         mock_get.return_value = {"id": "TEST", "name": "Test Space"}
         result = confluence_cloud.get_space("TEST")
-        mock_get.assert_called_once_with("space/TEST", **{})
+        mock_get.assert_called_once_with("spaces/TEST", **{})
         assert result == {"id": "TEST", "name": "Test Space"}
 
     @patch.object(ConfluenceCloud, "post")
     def test_create_space(self, mock_post, confluence_cloud):
-        """Test create_space method."""
+        """create_space calls the v2 plural endpoint."""
         space_data = {"name": "New Space", "key": "NEW"}
         mock_post.return_value = {"id": "NEW", "name": "New Space", "key": "NEW"}
         result = confluence_cloud.create_space(space_data)
-        mock_post.assert_called_once_with("space", data=space_data, **{})
+        mock_post.assert_called_once_with("spaces", data=space_data, **{})
         assert result == {"id": "NEW", "name": "New Space", "key": "NEW"}
 
     @patch.object(ConfluenceCloud, "put")
     def test_update_space(self, mock_put, confluence_cloud):
-        """Test update_space method."""
+        """update_space calls the v2 plural endpoint."""
         space_data = {"name": "Updated Space"}
         mock_put.return_value = {"id": "TEST", "name": "Updated Space"}
         result = confluence_cloud.update_space("TEST", space_data)
-        mock_put.assert_called_once_with("space/TEST", data=space_data, **{})
+        mock_put.assert_called_once_with("spaces/TEST", data=space_data, **{})
         assert result == {"id": "TEST", "name": "Updated Space"}
 
     @patch.object(ConfluenceCloud, "delete")
     def test_delete_space(self, mock_delete, confluence_cloud):
-        """Test delete_space method."""
+        """delete_space calls the v2 plural endpoint."""
         mock_delete.return_value = {"success": True}
         result = confluence_cloud.delete_space("TEST")
-        mock_delete.assert_called_once_with("space/TEST", **{})
+        mock_delete.assert_called_once_with("spaces/TEST", **{})
         assert result == {"success": True}
 
     @patch.object(ConfluenceCloud, "get")
     def test_get_space_content(self, mock_get, confluence_cloud):
-        """Test get_space_content method."""
+        """get_space_content calls the v2 plural endpoint."""
         mock_get.return_value = {"results": [{"id": "123", "title": "Page in Space"}]}
         result = confluence_cloud.get_space_content("TEST")
-        mock_get.assert_called_once_with("space/TEST/content", **{})
+        mock_get.assert_called_once_with("spaces/TEST/content", **{})
         assert result == {"results": [{"id": "123", "title": "Page in Space"}]}
 
     # User Management Tests