PR comments

jeffreyrainy · jeffreyrainy · commit a72e6f94f860 · 2021-02-25T21:26:01.000-05:00
diff --git a/com.unity.multiplayer.mlapi/Runtime/Core/NetworkedBehaviour.cs b/com.unity.multiplayer.mlapi/Runtime/Core/NetworkedBehaviour.cs
@@ -27,9 +27,9 @@ static class TickSystem
     {
         // todo: this might belong in the tick system, in the end
         // special value to indicate "No tick information"
-        public const ushort k_NoTick = 65535;
+        public const ushort k_NoTick = ushort.MaxValue;
         // Number of ticks over which the tick number wraps back to 0
-        public const ushort k_TickPeriod = 65000;
+        public const ushort k_TickPeriod = k_NoTick - 1;
 
         public static ushort GetTick()
         {
@@ -970,7 +970,7 @@ internal static void SetNetworkedVarData(List<INetworkedVar> networkedVarList, S
 
                     long readStartPos = stream.Position;
 
-                    networkedVarList[j].ReadField(stream, 0, 0);
+                    networkedVarList[j].ReadField(stream, TickSystem.k_NoTick, TickSystem.k_NoTick);
 
                     if (NetworkingManager.Singleton.NetworkConfig.EnsureNetworkedVarLengthSafety)
                     {

Original file line number	Diff line number	Diff line change
`@@ -27,9 +27,9 @@ static class TickSystem`
`27`	`27`	`{`
`28`	`28`	`// todo: this might belong in the tick system, in the end`
`29`	`29`	`// special value to indicate "No tick information"`
`30`		`- public const ushort k_NoTick = 65535;`
	`30`	`+ public const ushort k_NoTick = ushort.MaxValue;`
`31`	`31`	`// Number of ticks over which the tick number wraps back to 0`
`32`		`- public const ushort k_TickPeriod = 65000;`
	`32`	`+ public const ushort k_TickPeriod = k_NoTick - 1;`
`33`	`33`
`34`	`34`	`public static ushort GetTick()`
`35`	`35`	`{`
`@@ -970,7 +970,7 @@ internal static void SetNetworkedVarData(List<INetworkedVar> networkedVarList, S`
`970`	`970`
`971`	`971`	`long readStartPos = stream.Position;`
`972`	`972`
`973`		`- networkedVarList[j].ReadField(stream, 0, 0);`
	`973`	`+ networkedVarList[j].ReadField(stream, TickSystem.k_NoTick, TickSystem.k_NoTick);`
`974`	`974`
`975`	`975`	`if (NetworkingManager.Singleton.NetworkConfig.EnsureNetworkedVarLengthSafety)`
`976`	`976`	`{`