Don't allocate strings

Author: kvassall-unity

com.unity.multiplayer.mlapi/Runtime/Profiling/ProfilerConstants.cs

@@ -1,21 +1,20 @@
 namespace MLAPI.Profiling
 {
-    public enum ProfilerConstants
-    {
-        NumberOfConnections,
-        ReceiveTickRate,
+    public static class ProfilerConstants {
+        public const string NumberOfConnections = nameof(NumberOfConnections);
+        public const string ReceiveTickRate = nameof(ReceiveTickRate);
 
-        NumberOfNamedMessages,
-        NumberOfUnnamedMessages,
-        NumberBytesSent,
-        NumberBytesReceived,
-        NumberNetworkVarsReceived,
-        NumberOfRPCsSent,
-        NumberOfRPCsReceived,
-        NumberOfRPCBatchesSent,
-        NumberOfRPCBatchesReceived,
-        NumberOfRPCQueueProcessed,
-        NumberOfRPCsInQueueSize,
-        NumberOfRPCsOutQueueSize,
+        public const string NumberOfNamedMessages = nameof(NumberOfNamedMessages);
+        public const string NumberOfUnnamedMessages = nameof(NumberOfUnnamedMessages);
+        public const string NumberBytesSent = nameof(NumberBytesSent);
+        public const string NumberBytesReceived = nameof(NumberBytesReceived);
+        public const string NumberNetworkVarsReceived = nameof(NumberNetworkVarsReceived);
+        public const string NumberOfRPCsSent = nameof(NumberOfRPCsSent);
+        public const string NumberOfRPCsReceived = nameof(NumberOfRPCsReceived);
+        public const string NumberOfRPCBatchesSent = nameof(NumberOfRPCBatchesSent);
+        public const string NumberOfRPCBatchesReceived = nameof(NumberOfRPCBatchesReceived);
+        public const string NumberOfRPCQueueProcessed = nameof(NumberOfRPCQueueProcessed);
+        public const string NumberOfRPCsInQueueSize = nameof(NumberOfRPCsInQueueSize);
+        public const string NumberOfRPCsOutQueueSize = nameof(NumberOfRPCsOutQueueSize);
     }
 }

com.unity.multiplayer.mlapi/Runtime/Transports/UNET/ProfilerConstants.cs

@@ -1,8 +1,8 @@
 namespace MLAPI.Transports.UNET
 {
-    public enum ProfilerConstants
+    public static class ProfilerConstants
     {
-        NumberOfTransportSends,
-        NumberOfTransportSendQueues,
+        public const string NumberOfTransportSends = nameof(NumberOfTransportSends);
+        public const string NumberOfTransportSendQueues = nameof(NumberOfTransportSendQueues);
     }
 }

com.unity.multiplayer.mlapi/Runtime/Transports/UNET/UnetTransport.cs

@@ -82,7 +82,7 @@ public override void Send(ulong clientId, ArraySegment<byte> data, Channel chann
         {
             if (profilerEnabled)
             {
-                k_TransportProfilerData.Increment(ProfilerConstants.NumberOfTransportSends.ToString());
+                k_TransportProfilerData.Increment(ProfilerConstants.NumberOfTransportSends);
             }
 
             GetUnetConnectionDetails(clientId, out byte hostId, out ushort connectionId);
@@ -142,7 +142,7 @@ public void SendQueued(ulong clientId)
         {
             if (profilerEnabled)
             {
-                k_TransportProfilerData.Increment(ProfilerConstants.NumberOfTransportSendQueues.ToString());
+                k_TransportProfilerData.Increment(ProfilerConstants.NumberOfTransportSendQueues);
             }
 
             GetUnetConnectionDetails(clientId, out byte hostId, out ushort connectionId);