fix: no singletons, extra doc

Author: jeffreyrainy

com.unity.multiplayer.mlapi/Runtime/Core/NetworkTickSystem.cs

@@ -3,6 +3,11 @@
 
 namespace MLAPI
 {
+    // todo: This is a pretty minimal tick system. It will be improved in the future
+    // It currently relies on Time.unscaledTime and, as such, will start suffering
+    // numerical precision issues after 2^23 ticks have passed (float have 23 bits mantissa)
+    // For future releases, we'll need to improve on this, probably by leveraging FixedUpdate
+
     public class NetworkTickSystem : INetworkUpdateSystem, IDisposable
     {
         private const float k_DefaultTickIntervalSec = 1/60f; // Defaults to 60 ticks second
@@ -16,24 +21,12 @@ public class NetworkTickSystem : INetworkUpdateSystem, IDisposable
         // Number of ticks over which the tick number wraps back to 0
         public const ushort k_TickPeriod = k_NoTick - 1;
 
-        public static NetworkTickSystem Instance
-        {
-            get
-            {
-                if (m_Instance == null)
-                {
-                    m_Instance = new NetworkTickSystem();
-                }
-                return m_Instance;
-            }
-        }
-
         /// <summary>
         /// Constructor
         /// Defaults to k_DefaultTickIntervalSec if no tick duration is specified
         /// </summary>
         /// <param name="tickIntervalSec">Duration of a network tick</param>
-        private NetworkTickSystem(float tickIntervalSec = k_DefaultTickIntervalSec)
+        public NetworkTickSystem(float tickIntervalSec = k_DefaultTickIntervalSec)
         {
             this.RegisterNetworkUpdate(NetworkUpdateStage.EarlyUpdate);
 

com.unity.multiplayer.mlapi/Runtime/Core/NetworkingManager.cs

@@ -71,6 +71,7 @@ public class NetworkingManager : MonoBehaviour, INetworkUpdateSystem
         static ProfilerMarker s_InvokeRPC = new ProfilerMarker("InvokeRPC");
 #endif
         internal RpcQueueContainer rpcQueueContainer { get; private set; }
+        internal NetworkTickSystem networkTickSystem { get; private set; }
 
         /// <summary>
         /// A synchronized time, represents the time in seconds since the server application started. Is replicated across all clients
@@ -383,6 +384,12 @@ private void Init(bool server)
                 return;
             }
 
+            //This 'if' should never enter
+            if (networkTickSystem != null)
+            {
+                networkTickSystem.Dispose();
+            }
+            networkTickSystem = new NetworkTickSystem();
 
             //This should never happen, but in the event that it does there should be (at a minimum) a unity error logged.
             if(rpcQueueContainer != null)
@@ -698,6 +705,12 @@ public void Shutdown()
                 rpcQueueContainer = null;
             }
 
+            if (networkTickSystem != null)
+            {
+                networkTickSystem.Dispose();
+            }
+            networkTickSystem = null;
+
             NetworkProfiler.Stop();
             IsListening = false;
             IsServer = false;