[YouTube] Only fetch the Android mobile API for video streams

Also fixes the double fetch of the desktop player API when the content is protected by signatureCiphers when we know the sts string.

Format some code, remove an unused import.

Author: AudricV

extractor/src/main/java/org/schabi/newpipe/extractor/services/youtube/extractors/YoutubeStreamExtractor.java

@@ -42,7 +42,6 @@
 import java.time.format.DateTimeFormatter;
 import java.util.*;
 
-import static org.schabi.newpipe.extractor.services.youtube.YoutubeDashManifestCreator.createDashManifestFromOtfStreamingUrl;
 import static org.schabi.newpipe.extractor.services.youtube.YoutubeDashManifestCreator.createDashManifestFromPostLiveStreamDvrStreamingUrl;
 import static org.schabi.newpipe.extractor.services.youtube.YoutubeParsingHelper.*;
 import static org.schabi.newpipe.extractor.utils.Utils.EMPTY_STRING;
@@ -80,7 +79,7 @@ public static class DeobfuscateException extends ParsingException {
         }
     }
 
-    /*//////////////////////////////////////////////////////////////////////////*/
+    /*////////////////////////////////////////////////////////////////////////*/
 
     @Nullable
     private static String cachedDeobfuscationCode = null;
@@ -91,6 +90,7 @@ public static class DeobfuscateException extends ParsingException {
 
     private JsonObject playerResponse;
     private JsonObject nextResponse;
+    private StreamType streamType;
 
     @Nullable
     private JsonObject desktopStreamingData;
@@ -689,13 +689,7 @@ public List<SubtitlesStream> getSubtitles(final MediaFormat format) throws Parsi
     public StreamType getStreamType() {
         assertPageFetched();
 
-        if (playerResponse.getObject("playabilityStatus").has("liveStreamability")) {
-            return StreamType.LIVE_STREAM;
-        } else if (playerResponse.getObject("videoDetails").getBoolean("isPostLiveDvr", false)) {
-            return StreamType.POST_LIVE_STREAM;
-        } else {
-            return StreamType.VIDEO_STREAM;
-        }
+        return streamType;
     }
 
     @Nullable
@@ -792,18 +786,39 @@ public void onFetchPage(@Nonnull final Downloader downloader)
 
         final JsonObject playabilityStatus = playerResponse.getObject("playabilityStatus");
 
-        boolean ageRestricted = playabilityStatus.getString("reason", EMPTY_STRING)
+        final boolean isAgeRestricted = playabilityStatus.getString("reason", EMPTY_STRING)
                 .contains("age");
 
         if (!playerResponse.has("streamingData")) {
             try {
                 fetchDesktopEmbedJsonPlayer(contentCountry, localization, videoId);
             } catch (final Exception ignored) {
             }
+
+            if (playerResponse.getObject("playabilityStatus").has("liveStreamability")) {
+                streamType = StreamType.LIVE_STREAM;
+            } else if (playerResponse.getObject("videoDetails").getBoolean("isPostLiveDvr",
+                    false)) {
+                streamType = StreamType.POST_LIVE_STREAM;
+            } else {
+                streamType = StreamType.VIDEO_STREAM;
+            }
+
             try {
-                fetchAndroidEmbedJsonPlayer(contentCountry, localization, videoId);
+                if (streamType == StreamType.VIDEO_STREAM || desktopStreamingData == null) {
+                    fetchAndroidEmbedJsonPlayer(contentCountry, localization, videoId);
+                }
             } catch (final Exception ignored) {
             }
+        } else {
+            if (playerResponse.getObject("playabilityStatus").has("liveStreamability")) {
+                streamType = StreamType.LIVE_STREAM;
+            } else if (playerResponse.getObject("videoDetails").getBoolean("isPostLiveDvr",
+                    false)) {
+                streamType = StreamType.POST_LIVE_STREAM;
+            } else {
+                streamType = StreamType.VIDEO_STREAM;
+            }
         }
 
         if (desktopStreamingData == null && playerResponse.has("streamingData")) {
@@ -814,7 +829,7 @@ public void onFetchPage(@Nonnull final Downloader downloader)
             checkPlayabilityStatus(youtubePlayerResponse, playabilityStatus);
         }
 
-        if (ageRestricted) {
+        if (isAgeRestricted) {
             final byte[] ageRestrictedBody = JsonWriter.string(prepareDesktopEmbedVideoJsonBuilder(
                     localization, contentCountry, videoId)
                     .done())
@@ -824,14 +839,15 @@ public void onFetchPage(@Nonnull final Downloader downloader)
             nextResponse = getJsonPostResponse("next", body, localization);
         }
 
-        if (!ageRestricted) {
+        if (!isAgeRestricted && (streamType == StreamType.VIDEO_STREAM
+                || desktopStreamingData == null)) {
             try {
                 fetchAndroidMobileJsonPlayer(contentCountry, localization, videoId);
             } catch (final Exception ignored) {
             }
         }
 
-        if (isCipherProtectedContent()) {
+        if (!isAgeRestricted && isCipherProtectedContent() && sts == null) {
             fetchDesktopJsonPlayerWithSts(contentCountry, localization, videoId);
         }
     }
@@ -860,28 +876,24 @@ private void checkPlayabilityStatus(final JsonObject youtubePlayerResponse,
                             "This age-restricted video cannot be watched.");
                 }
             }
-            if (status.equalsIgnoreCase("unplayable")) {
-                if (reason != null) {
-                    if (reason.contains("Music Premium")) {
-                        throw new YoutubeMusicPremiumContentException();
-                    }
-                    if (reason.contains("payment")) {
-                        throw new PaidContentException("This video is a paid video");
-                    }
-                    if (reason.contains("members-only")) {
-                        throw new PaidContentException(
-                                "This video is only available for members of the channel of this video");
-                    }
-                    if (reason.contains("unavailable")) {
-                        final String detailedErrorMessage = getTextFromObject(playabilityStatus
-                                .getObject("errorScreen").getObject("playerErrorMessageRenderer")
-                                .getObject("subreason"));
-                        if (detailedErrorMessage != null) {
-                            if (detailedErrorMessage.contains("country")) {
-                                throw new GeographicRestrictionException(
-                                        "This video is not available in user's country.");
-                            }
-                        }
+            if (status.equalsIgnoreCase("unplayable") && reason != null) {
+                if (reason.contains("Music Premium")) {
+                    throw new YoutubeMusicPremiumContentException();
+                }
+                if (reason.contains("payment")) {
+                    throw new PaidContentException("This video is a paid video");
+                }
+                if (reason.contains("members-only")) {
+                    throw new PaidContentException(
+                            "This video is only available for members of the channel of this video");
+                }
+                if (reason.contains("unavailable")) {
+                    final String detailedErrorMessage = getTextFromObject(playabilityStatus
+                            .getObject("errorScreen").getObject("playerErrorMessageRenderer")
+                            .getObject("subreason"));
+                    if (detailedErrorMessage != null && detailedErrorMessage.contains("country")) {
+                        throw new GeographicRestrictionException(
+                                "This video is not available in user's country.");
                     }
                 }
             }