Return attributes always in reverse-XML order

Author: borgand

lib/onelogin/ruby-saml/response.rb

@@ -50,6 +50,7 @@ def sessionindex
 
       # A hash of all the attributes with the response.
       # Multiple values will be returned in the AttributeValue#values array
+      # in reverse order, when compared to XML
       def attributes
         @attr_statements ||= begin
           result = {}
@@ -62,7 +63,7 @@ def attributes
             values = attr_element.elements.collect(&:text)
 
             # Set up a string-like wrapper for the values array
-            attr_value = AttributeValue.new(values.first, values)
+            attr_value = AttributeValue.new(values.first, values.reverse)
             # Merge values if the Attribute has already been seen
             if result[name]
               attr_value.values += result[name].values

test/response_test.rb

@@ -237,7 +237,7 @@ class RubySamlTest < Test::Unit::TestCase
 
         should "return array with all attributes when asked" do
           response = OneLogin::RubySaml::Response.new(fixture(:response_with_multiple_attribute_values))
-          assert_equal ['value1', 'value2'], response.attributes[:another_value].values
+          assert_equal ['value2', 'value1'], response.attributes[:another_value].values
         end
 
         should "return last of multiple values when multiple Attribute tags in XML" do