Skip to content

Commit be53db1

Browse files
committed
Change error "The SPNameQualifier value mistmatch the SP entityID value." to "SPNameQualifier value does not match the SP entityID value."
1 parent 626140b commit be53db1

3 files changed

Lines changed: 3 additions & 2 deletions

File tree

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
* [#690](https://github.com/SAML-Toolkits/ruby-saml/pull/690) Remove deprecated `settings.security[:embed_sign]` parameter.
1212
* [#697](https://github.com/SAML-Toolkits/ruby-saml/pull/697) Add deprecation for various parameters in `RubySaml::Settings`.
1313
* [#709](https://github.com/SAML-Toolkits/ruby-saml/pull/709) Allow passing in `Net::HTTP` `:open_timeout`, `:read_timeout`, and `:max_retries` settings to `IdpMetadataParser#parse_remote`.
14+
* [#715](https://github.com/SAML-Toolkits/ruby-saml/pull/715) Fix typo in error when SPNameQualifier value does not match the SP entityID.
1415

1516
### 1.17.0
1617
* [#687](https://github.com/SAML-Toolkits/ruby-saml/pull/687) Add CI coverage for Ruby 3.3 and Windows.

lib/ruby_saml/response.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -804,7 +804,7 @@ def validate_name_id
804804
end
805805

806806
if !(settings.sp_entity_id.nil? || settings.sp_entity_id.empty? || name_id_spnamequalifier.nil? || name_id_spnamequalifier.empty?) && (name_id_spnamequalifier != settings.sp_entity_id)
807-
return append_error("The SPNameQualifier value mistmatch the SP entityID value.")
807+
return append_error('SPNameQualifier value does not match the SP entityID value.')
808808
end
809809
end
810810

test/response_test.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1027,7 +1027,7 @@ def generate_audience_error(expected, actual)
10271027
settings.sp_entity_id = 'sp_entity_id'
10281028
response_wrong_spnamequalifier.settings = settings
10291029
assert !response_wrong_spnamequalifier.send(:validate_name_id)
1030-
assert_includes response_wrong_spnamequalifier.errors, "The SPNameQualifier value mistmatch the SP entityID value."
1030+
assert_includes response_wrong_spnamequalifier.errors, 'SPNameQualifier value does not match the SP entityID value.'
10311031
end
10321032

10331033
it "return true when no nameid element but not required by settings" do

0 commit comments

Comments
 (0)