Remove unnecesary line. Add explanation of the HashWithIndifferentAccess issue

Author: pitbulk

lib/onelogin/ruby-saml/authrequest.rb

@@ -27,8 +27,9 @@ def create(settings, params = {})
       end
 
       def create_params(settings, params={})
-        params = {} if params.nil?
-        # Some ruby-saml versions uses :RelayState others use 'RelayState'
+        # The method expects :RelayState but sometimes we get 'RelayState' instead.
+        # Based on the HashWithIndifferentAccess value in Rails we could experience
+        # conflicts so this line will solve them.
         relay_state = params[:RelayState] || params['RelayState']
 
         request_doc = create_authentication_xml_doc(settings)

lib/onelogin/ruby-saml/logoutrequest.rb

@@ -25,8 +25,9 @@ def create(settings, params={})
       end
 
       def create_params(settings, params={})
-        params = {} if params.nil?
-        # Some ruby-saml versions uses :RelayState others use 'RelayState'
+        # The method expects :RelayState but sometimes we get 'RelayState' instead.
+        # Based on the HashWithIndifferentAccess value in Rails we could experience
+        # conflicts so this line will solve them.
         relay_state = params[:RelayState] || params['RelayState']
 
         request_doc = create_logout_request_xml_doc(settings)

lib/onelogin/ruby-saml/slo_logoutresponse.rb

@@ -26,7 +26,6 @@ def create(settings, request_id = nil, logout_message = nil, params = {})
       end
 
       def create_params(settings, request_id = nil, logout_message = nil, params = {})
-        params = {} if params.nil?
         # Some ruby-saml versions uses :RelayState others use 'RelayState'
         relay_state = params[:RelayState] || params['RelayState']