Merge pull request #186 from LukasReschke/add-invalid-entity-id-to-exception

Add invalid entityId to Exception

Author: pitbulk

lib/Saml2/Response.php

@@ -256,7 +256,7 @@ public function isValid($requestId = null)
                     $trimmedIssuer = trim($issuer);
                     if (empty($trimmedIssuer) || $trimmedIssuer !== $idPEntityId) {
                         throw new OneLogin_Saml2_ValidationError(
-                            "Invalid issuer in the Assertion/Response",
+                            "Invalid issuer in the Assertion/Response (expected '$idPEntityId', got '$trimmedIssuer')",
                             OneLogin_Saml2_ValidationError::WRONG_ISSUER
                         );
                     }

tests/src/OneLogin/Saml2/ResponseTest.php

@@ -952,12 +952,12 @@ public function testIsInValidIssuer()
         $response3 = new OneLogin_Saml2_Response($this->_settings, $message);
 
         $this->assertFalse($response3->isValid());
-        $this->assertEquals('Invalid issuer in the Assertion/Response', $response3->getError());
+        $this->assertEquals('Invalid issuer in the Assertion/Response (expected \'http://idp.example.com/\', got \'http://invalid.issuer.example.com/\')', $response3->getError());
 
         $response4 = new OneLogin_Saml2_Response($this->_settings, $message2);
 
         $this->assertFalse($response4->isValid());
-        $this->assertEquals('Invalid issuer in the Assertion/Response', $response4->getError());
+        $this->assertEquals('Invalid issuer in the Assertion/Response (expected \'http://idp.example.com/\', got \'http://invalid.isser.example.com/\')', $response4->getError());
     }
 
     /**