Skip to content

Commit 8651e12

Browse files
author
James Grant
committed
Added ability to configure DigestAlgorithm in settings
1 parent 5099e97 commit 8651e12

2 files changed

Lines changed: 9 additions & 1 deletion

File tree

advanced_settings_example.php

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -85,6 +85,13 @@
8585
// 'http://www.w3.org/2001/04/xmldsig-more#rsa-sha512'
8686
'signatureAlgorithm' => 'http://www.w3.org/2000/09/xmldsig#rsa-sha1',
8787

88+
// Algorithm that the toolkit will use on digest process. Options:
89+
// 'http://www.w3.org/2000/09/xmldsig#sha1'
90+
// 'http://www.w3.org/2001/04/xmlenc#sha256'
91+
// 'http://www.w3.org/2001/04/xmldsig-more#sha384'
92+
// 'http://www.w3.org/2001/04/xmlenc#sha512'
93+
'digestAlgorithm' => 'http://www.w3.org/2000/09/xmldsig#sha1',
94+
8895
// ADFS URL-Encodes SAML data as lowercase, and the toolkit by default uses
8996
// uppercase. Turn it True for ADFS compatibility on signature verification
9097
'lowercaseUrlencoding' => false,

lib/Saml2/Settings.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -835,7 +835,8 @@ public function getSPMetadata()
835835
}
836836

837837
$signatureAlgorithm = $this->_security['signatureAlgorithm'];
838-
$metadata = OneLogin_Saml2_Metadata::signMetadata($metadata, $keyMetadata, $certMetadata, $signatureAlgorithm);
838+
$digestAlgorithm = $this->_security['digestAlgorithm'];
839+
$metadata = OneLogin_Saml2_Metadata::signMetadata($metadata, $keyMetadata, $certMetadata, $signatureAlgorithm, $digestAlgorithm);
839840
}
840841
return $metadata;
841842
}

0 commit comments

Comments
 (0)