Skip to content

Commit b943aa0

Browse files
author
Steven Orvell
committed
[skip ci] doc fixes
1 parent 4eb252f commit b943aa0

2 files changed

Lines changed: 9 additions & 5 deletions

File tree

lib/mixins/property-accessors.html

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -477,11 +477,12 @@
477477
}
478478

479479
/**
480-
* Call to enable property accessors. This method must be called
481-
* for any side effects of setting properties to occur. For elements,
482-
* generally `connectedCallback` is a normal spot to do so.
483-
* It is safe to call this method multiple times as it only turns
484-
* on property accessors once.
480+
* Call to enable property accessor processing. Before this method is
481+
* called accessor values will be set but side effects are
482+
* queued. When called, any pending side effects occur immediately.
483+
* For elements, generally `connectedCallback` is a normal spot to do so.
484+
* It is safe to call this method multiple times as it only turns on
485+
* property accessors once.
485486
*/
486487
_enableProperties() {
487488
if (!this.__dataEnabled) {

lib/mixins/property-effects.html

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1432,6 +1432,9 @@
14321432
if (!this.__dataClientsInitialized) {
14331433
this.__dataClientsInitialized = true;
14341434
this._readyClients();
1435+
// Override point where accessors are turned on; importantly,
1436+
// this is after clients have fully readied, providing a guarantee
1437+
// that any property effects occur only after all clients are ready.
14351438
this.__dataInitialized = true;
14361439
} else {
14371440
// Flush all clients

0 commit comments

Comments
 (0)