Skip to content

Commit a2fa100

Browse files
committed
lint and compile successfully
1 parent 70a5464 commit a2fa100

12 files changed

Lines changed: 112 additions & 101 deletions

externs/closure-types.js

Lines changed: 98 additions & 43 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
*
66
* This file is generated, do not edit manually
77
*/
8-
/* eslint-disable no-unused-vars */
8+
/* eslint-disable no-unused-vars, strict */
99

1010
/**
1111
* @record
@@ -19,6 +19,10 @@ Polymer_PropertyAccessors.prototype._initializeProperties = function(){};
1919
*/
2020
Polymer_PropertyAccessors.prototype._initializeProtoProperties = function(props){};
2121
/**
22+
* @param {Object} props
23+
*/
24+
Polymer_PropertyAccessors.prototype._initializeInstanceProperties = function(props){};
25+
/**
2226
* @param {string} attribute
2327
* @param {string} value
2428
*/
@@ -59,12 +63,18 @@ Polymer_PropertyAccessors.prototype._deserializeValue = function(value, type){};
5963
Polymer_PropertyAccessors.prototype._createPropertyAccessor = function(property, readOnly){};
6064
/**
6165
* @param {string} property
66+
* @return {boolean}
67+
*/
68+
Polymer_PropertyAccessors.prototype._hasAccessor = function(property){};
69+
/**
70+
* @param {string} property
6271
* @param {*} value
6372
*/
6473
Polymer_PropertyAccessors.prototype._setProperty = function(property, value){};
6574
/**
6675
* @param {string} property
6776
* @param {*} value
77+
* @return {boolean}
6878
*/
6979
Polymer_PropertyAccessors.prototype._setPendingProperty = function(property, value){};
7080
/**
@@ -79,6 +89,9 @@ Polymer_PropertyAccessors.prototype._invalidateProperties = function(){};
7989
*/
8090
Polymer_PropertyAccessors.prototype._flushProperties = function(){};
8191
/**
92+
*/
93+
Polymer_PropertyAccessors.prototype.ready = function(){};
94+
/**
8295
* @param {Object} currentProps
8396
* @param {Object} changedProps
8497
* @param {Object} oldProps
@@ -96,30 +109,31 @@ Polymer_PropertyAccessors.prototype._shouldPropertyChange = function(property, v
96109
*/
97110
function Polymer_TemplateStamp(){}
98111
/**
99-
* @param {HTMLTemplateElement} template
100112
*/
101-
Polymer_TemplateStamp.prototype._stampTemplate = function(template){};
113+
Polymer_TemplateStamp.prototype._initializeProperties = function(){};
102114
/**
103-
* @param {*} template
115+
* @param {HTMLTemplateElement} template
116+
* @return {DocumentFragment}
104117
*/
105-
Polymer_TemplateStamp.prototype._parseTemplateAnnotations = function(template){};
118+
Polymer_TemplateStamp.prototype._stampTemplate = function(template){};
106119
/**
107-
* @param {*} node
108-
* @param {*} eventName
109-
* @param {*} methodName
110-
* @param {*} context
120+
* @param {Node} node
121+
* @param {string} eventName
122+
* @param {string} methodName
123+
* @param {*=} context
124+
* @return {Function}
111125
*/
112126
Polymer_TemplateStamp.prototype._addMethodEventListenerToNode = function(node, eventName, methodName, context){};
113127
/**
114-
* @param {*} node
115-
* @param {*} eventName
116-
* @param {*} handler
128+
* @param {Node} node
129+
* @param {string} eventName
130+
* @param {Function} handler
117131
*/
118132
Polymer_TemplateStamp.prototype._addEventListenerToNode = function(node, eventName, handler){};
119133
/**
120-
* @param {*} node
121-
* @param {*} eventName
122-
* @param {*} handler
134+
* @param {Node} node
135+
* @param {string} eventName
136+
* @param {Function} handler
123137
*/
124138
Polymer_TemplateStamp.prototype._removeEventListenerFromNode = function(node, eventName, handler){};
125139
/**
@@ -129,20 +143,33 @@ Polymer_TemplateStamp.prototype._removeEventListenerFromNode = function(node, ev
129143
*/
130144
function Polymer_PropertyEffects(){}
131145
/**
146+
* @override
132147
*/
133148
Polymer_PropertyEffects.prototype._initializeProperties = function(){};
134149
/**
150+
* @override
135151
* @param {*} props
136152
*/
137153
Polymer_PropertyEffects.prototype._initializeProtoProperties = function(props){};
138154
/**
139-
* @param {*} property
155+
* @override
156+
* @param {*} props
157+
*/
158+
Polymer_PropertyEffects.prototype._initializeInstanceProperties = function(props){};
159+
/**
160+
* @param {string} property
140161
* @param {string} type
141162
* @param {Object=} effect
142163
*/
143164
Polymer_PropertyEffects.prototype._addPropertyEffect = function(property, type, effect){};
144165
/**
145166
* @param {string} property
167+
* @param {string} type
168+
* @param {Object=} effect
169+
*/
170+
Polymer_PropertyEffects.prototype._removePropertyEffect = function(property, type, effect){};
171+
/**
172+
* @param {string} property
146173
* @param {string=} type
147174
* @return {boolean}
148175
*/
@@ -170,7 +197,7 @@ Polymer_PropertyEffects.prototype._hasComputedEffect = function(property){};
170197
/**
171198
* @param {(string|!Array.<(number|string)>)} path
172199
* @param {*} value
173-
* @param {*} shouldNotify
200+
* @param {boolean=} shouldNotify
174201
* @param {boolean=} isPathNotification
175202
* @return {boolean}
176203
*/
@@ -182,17 +209,20 @@ Polymer_PropertyEffects.prototype._setPendingPropertyOrPath = function(path, val
182209
*/
183210
Polymer_PropertyEffects.prototype._setUnmanagedPropertyToNode = function(node, prop, value){};
184211
/**
212+
* @override
185213
* @param {*} property
186214
* @param {*} value
187215
* @param {*} shouldNotify
188216
*/
189217
Polymer_PropertyEffects.prototype._setPendingProperty = function(property, value, shouldNotify){};
190218
/**
219+
* @override
191220
* @param {*} property
192221
* @param {*} value
193222
*/
194223
Polymer_PropertyEffects.prototype._setProperty = function(property, value){};
195224
/**
225+
* @override
196226
*/
197227
Polymer_PropertyEffects.prototype._invalidateProperties = function(){};
198228
/**
@@ -204,29 +234,30 @@ Polymer_PropertyEffects.prototype._enqueueClient = function(client){};
204234
Polymer_PropertyEffects.prototype._flushClients = function(){};
205235
/**
206236
* @param {Object} props
237+
* @param {boolean=} setReadOnly
207238
*/
208-
Polymer_PropertyEffects.prototype.setProperties = function(props){};
209-
/**
210-
*/
211-
Polymer_PropertyEffects.prototype._flushProperties = function(){};
239+
Polymer_PropertyEffects.prototype.setProperties = function(props, setReadOnly){};
212240
/**
241+
* @override
213242
*/
214243
Polymer_PropertyEffects.prototype.ready = function(){};
215244
/**
216245
*/
217246
Polymer_PropertyEffects.prototype._readyClients = function(){};
218247
/**
219-
* @param {HTMLTemplateElement} template
220-
* @return {DocumentFragment}
221-
*/
222-
Polymer_PropertyEffects.prototype._stampTemplate = function(template){};
223-
/**
248+
* @override
224249
* @param {*} currentProps
225250
* @param {*} changedProps
226251
* @param {*} oldProps
227252
*/
228253
Polymer_PropertyEffects.prototype._propertiesChanged = function(currentProps, changedProps, oldProps){};
229254
/**
255+
* @param {Object} changedProps
256+
* @param {Object} oldProps
257+
* @param {boolean} hasPaths
258+
*/
259+
Polymer_PropertyEffects.prototype._propagatePropertyChanges = function(changedProps, oldProps, hasPaths){};
260+
/**
230261
* @param {(string|!Array.<(string|number)>)} to
231262
* @param {(string|!Array.<(string|number)>)} from
232263
*/
@@ -319,24 +350,42 @@ Polymer_PropertyEffects.prototype._createReflectedProperty = function(property){
319350
Polymer_PropertyEffects.prototype._createComputedProperty = function(property, expression, dynamicFns){};
320351
/**
321352
* @param {HTMLTemplateElement} template
322-
* @param {Object=} dynamicFns
353+
* @param {boolean=} instanceBinding
354+
* @return {Object}
323355
*/
324-
Polymer_PropertyEffects.prototype._bindTemplate = function(template, dynamicFns){};
356+
Polymer_PropertyEffects.prototype._bindTemplate = function(template, instanceBinding){};
357+
/**
358+
* @param {HTMLTemplateElement} template
359+
* @return {DocumentFragment}
360+
*/
361+
Polymer_PropertyEffects.prototype._stampTemplate = function(template){};
362+
/**
363+
* @param {DocumentFragment} dom
364+
*/
365+
Polymer_PropertyEffects.prototype._removeBoundDom = function(dom){};
325366
/**
326367
* @record
327368
* @extends {Polymer_PropertyEffects}
328369
*/
329370
function Polymer_ElementMixin(){}
330371
/**
372+
* @override
331373
*/
332374
Polymer_ElementMixin.prototype._initializeProperties = function(){};
333375
/**
376+
* @override
334377
*/
335378
Polymer_ElementMixin.prototype.connectedCallback = function(){};
336379
/**
380+
* @override
337381
*/
338382
Polymer_ElementMixin.prototype.disconnectedCallback = function(){};
339383
/**
384+
* @override
385+
*/
386+
Polymer_ElementMixin.prototype.ready = function(){};
387+
/**
388+
* @override
340389
*/
341390
Polymer_ElementMixin.prototype._readyClients = function(){};
342391
/**
@@ -345,6 +394,7 @@ Polymer_ElementMixin.prototype._readyClients = function(){};
345394
*/
346395
Polymer_ElementMixin.prototype._attachDom = function(dom){};
347396
/**
397+
* @override
348398
* @param {*} name
349399
* @param {*} old
350400
* @param {*} value
@@ -395,12 +445,14 @@ Polymer_LegacyElementMixin.prototype.detached = function(){};
395445
*/
396446
Polymer_LegacyElementMixin.prototype.attributeChanged = function(){};
397447
/**
448+
* @override
398449
*/
399450
Polymer_LegacyElementMixin.prototype._initializeProperties = function(){};
400451
/**
401452
*/
402453
Polymer_LegacyElementMixin.prototype._registered = function(){};
403454
/**
455+
* @override
404456
*/
405457
Polymer_LegacyElementMixin.prototype.ready = function(){};
406458
/**
@@ -417,6 +469,7 @@ Polymer_LegacyElementMixin.prototype.serialize = function(value){};
417469
/**
418470
* @param {string} value
419471
* @param {*} type
472+
* @return {*}
420473
*/
421474
Polymer_LegacyElementMixin.prototype.deserialize = function(value, type){};
422475
/**
@@ -444,10 +497,11 @@ Polymer_LegacyElementMixin.prototype.extend = function(prototype, api){};
444497
*/
445498
Polymer_LegacyElementMixin.prototype.mixin = function(target, source){};
446499
/**
447-
* @param {*} object
448-
* @param {*} inherited
500+
* @param {Object} object
501+
* @param {Object} prototype
502+
* @return {Object}
449503
*/
450-
Polymer_LegacyElementMixin.prototype.chainObject = function(object, inherited){};
504+
Polymer_LegacyElementMixin.prototype.chainObject = function(object, prototype){};
451505
/**
452506
* @param {HTMLTemplateElement} template
453507
* @return {DocumentFragment}
@@ -473,7 +527,7 @@ Polymer_LegacyElementMixin.prototype.listen = function(node, eventName, methodNa
473527
*/
474528
Polymer_LegacyElementMixin.prototype.unlisten = function(node, eventName, methodName){};
475529
/**
476-
* @param {String=} direction
530+
* @param {string=} direction
477531
* @param {HTMLElement=} node
478532
*/
479533
Polymer_LegacyElementMixin.prototype.setScrollDirection = function(direction, node){};
@@ -513,18 +567,18 @@ Polymer_LegacyElementMixin.prototype.queryEffectiveChildren = function(selector)
513567
*/
514568
Polymer_LegacyElementMixin.prototype.queryAllEffectiveChildren = function(selector){};
515569
/**
516-
* @param {String=} slctr
570+
* @param {string=} slctr
517571
* @return {Array.<Node>}
518572
*/
519573
Polymer_LegacyElementMixin.prototype.getContentChildNodes = function(slctr){};
520574
/**
521-
* @param {String=} slctr
575+
* @param {string=} slctr
522576
* @return {Array.<HTMLElement>}
523577
*/
524578
Polymer_LegacyElementMixin.prototype.getContentChildren = function(slctr){};
525579
/**
526580
* @param {?Node} node
527-
* @return {Boolean}
581+
* @return {boolean}
528582
*/
529583
Polymer_LegacyElementMixin.prototype.isLightDescendant = function(node){};
530584
/**
@@ -538,27 +592,28 @@ Polymer_LegacyElementMixin.prototype.isLocalDescendant = function(node){};
538592
*/
539593
Polymer_LegacyElementMixin.prototype.scopeSubtree = function(container, shouldObserve){};
540594
/**
541-
* @param {String} property
542-
* @return {String}
595+
* @param {string} property
596+
* @return {string}
543597
*/
544598
Polymer_LegacyElementMixin.prototype.getComputedStyleValue = function(property){};
545599
/**
546-
* @param {String} jobName
600+
* @param {string} jobName
547601
* @param {function ()} callback
548602
* @param {number} wait
603+
* @return {Object}
549604
*/
550605
Polymer_LegacyElementMixin.prototype.debounce = function(jobName, callback, wait){};
551606
/**
552-
* @param {String} jobName
607+
* @param {string} jobName
553608
* @return {boolean}
554609
*/
555610
Polymer_LegacyElementMixin.prototype.isDebouncerActive = function(jobName){};
556611
/**
557-
* @param {String} jobName
612+
* @param {string} jobName
558613
*/
559614
Polymer_LegacyElementMixin.prototype.flushDebouncer = function(jobName){};
560615
/**
561-
* @param {String} jobName
616+
* @param {string} jobName
562617
*/
563618
Polymer_LegacyElementMixin.prototype.cancelDebouncer = function(jobName){};
564619
/**
@@ -592,13 +647,13 @@ Polymer_LegacyElementMixin.prototype.importHref = function(href, onload, onerror
592647
*/
593648
Polymer_LegacyElementMixin.prototype.elementMatches = function(selector, node){};
594649
/**
595-
* @param {String} name
650+
* @param {string} name
596651
* @param {boolean=} bool
597652
* @param {HTMLElement=} node
598653
*/
599654
Polymer_LegacyElementMixin.prototype.toggleAttribute = function(name, bool, node){};
600655
/**
601-
* @param {String} name
656+
* @param {string} name
602657
* @param {boolean=} bool
603658
* @param {HTMLElement=} node
604659
*/

externs/polymer-externs.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
/**
77
* @param {!{is: string}} init
8-
* @return {!CustomElement}
8+
* @return {!HTMLElement}
99
*/
1010
function Polymer(init){}
1111

gulpfile.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,6 @@ gulp.task('closure', ['clean'], () => {
119119
rewrite_polyfills: false,
120120
new_type_inf: true,
121121
externs: [
122-
// 'externs/closure-upstream-externs.js',
123122
'externs/webcomponents-externs.js',
124123
'externs/polymer-externs.js',
125124
'externs/closure-types.js',
@@ -180,7 +179,6 @@ gulp.task('closure', ['clean'], () => {
180179
.pipe(project.bundler())
181180
.pipe(new Uniq())
182181
.pipe(splitter.split())
183-
.pipe(new Log('saw:'))
184182
.pipe(gulpif(splitRx, closurePipeline()))
185183
.pipe(splitter.rejoin())
186184
.pipe(gulpif(joinRx, minimalDocument()))

0 commit comments

Comments
 (0)