Temp fix for issue where the server despawns an object while the client wants to write to it

JayPeet · JayPeet · commit 3c3b18a05882 · 2022-08-21T19:30:59.000+01:00
diff --git a/com.unity.netcode.gameobjects/Runtime/Core/NetworkBehaviourUpdater.cs b/com.unity.netcode.gameobjects/Runtime/Core/NetworkBehaviourUpdater.cs
@@ -23,8 +23,8 @@ internal void NetworkBehaviourUpdate(NetworkManager networkManager)
         {
 #if DEVELOPMENT_BUILD || UNITY_EDITOR
             m_NetworkBehaviourUpdate.Begin();
-#endif
-            try
+#endif
+            try
             {
                 if (networkManager.IsServer)
                 {
@@ -57,6 +57,8 @@ internal void NetworkBehaviourUpdate(NetworkManager networkManager)
                 else
                 {
                     // when client updates the server, it tells it about all its objects
+                    m_DirtyNetworkObjects.RemoveWhere((sobj) => sobj == null);
+
                     foreach (var sobj in m_DirtyNetworkObjects)
                     {
                         if (sobj.IsOwner)

Original file line number	Diff line number	Diff line change
`@@ -23,8 +23,8 @@ internal void NetworkBehaviourUpdate(NetworkManager networkManager)`
`23`	`23`	`{`
`24`	`24`	`#if DEVELOPMENT_BUILD \|\| UNITY_EDITOR`
`25`	`25`	`m_NetworkBehaviourUpdate.Begin();`
`26`		`-#endif`
`27`		`- try`
	`26`	`+#endif`
	`27`	`+ try`
`28`	`28`	`{`
`29`	`29`	`if (networkManager.IsServer)`
`30`	`30`	`{`
`@@ -57,6 +57,8 @@ internal void NetworkBehaviourUpdate(NetworkManager networkManager)`
`57`	`57`	`else`
`58`	`58`	`{`
`59`	`59`	`// when client updates the server, it tells it about all its objects`
	`60`	`+ m_DirtyNetworkObjects.RemoveWhere((sobj) => sobj == null);`
	`61`	`+`
`60`	`62`	`foreach (var sobj in m_DirtyNetworkObjects)`
`61`	`63`	`{`
`62`	`64`	`if (sobj.IsOwner)`