Skip to content

Commit 93e0680

Browse files
ShadauxCatjakobbbb
authored andcommitted
fix: Corrects memory leak in MessageRegistrationTests (Unity-Technologies#2148)
1 parent 45cfa90 commit 93e0680

1 file changed

Lines changed: 7 additions & 7 deletions

File tree

com.unity.netcode.gameobjects/Tests/Editor/Messaging/MessageRegistrationTests.cs

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -137,9 +137,9 @@ public void WhenCreatingMessageSystem_OnlyProvidedTypesAreRegistered()
137137
{
138138
var sender = new NopMessageSender();
139139

140-
var systemOne = new MessagingSystem(sender, null, new TestMessageProviderOne());
141-
var systemTwo = new MessagingSystem(sender, null, new TestMessageProviderTwo());
142-
var systemThree = new MessagingSystem(sender, null, new TestMessageProviderThree());
140+
using var systemOne = new MessagingSystem(sender, null, new TestMessageProviderOne());
141+
using var systemTwo = new MessagingSystem(sender, null, new TestMessageProviderTwo());
142+
using var systemThree = new MessagingSystem(sender, null, new TestMessageProviderThree());
143143

144144
using (systemOne)
145145
using (systemTwo)
@@ -161,9 +161,9 @@ public void WhenCreatingMessageSystem_BoundTypeMessageHandlersAreRegistered()
161161
{
162162
var sender = new NopMessageSender();
163163

164-
var systemOne = new MessagingSystem(sender, null, new TestMessageProviderOne());
165-
var systemTwo = new MessagingSystem(sender, null, new TestMessageProviderTwo());
166-
var systemThree = new MessagingSystem(sender, null, new TestMessageProviderThree());
164+
using var systemOne = new MessagingSystem(sender, null, new TestMessageProviderOne());
165+
using var systemTwo = new MessagingSystem(sender, null, new TestMessageProviderTwo());
166+
using var systemThree = new MessagingSystem(sender, null, new TestMessageProviderThree());
167167

168168
using (systemOne)
169169
using (systemTwo)
@@ -235,7 +235,7 @@ public void MessagesGetPrioritizedCorrectly()
235235
{
236236
var sender = new NopMessageSender();
237237
var provider = new OrderingMessageProvider();
238-
var messagingSystem = new MessagingSystem(sender, null, provider);
238+
using var messagingSystem = new MessagingSystem(sender, null, provider);
239239

240240
// the 3 priority messages should appear first, in lexicographic order
241241
Assert.AreEqual(messagingSystem.MessageTypes[0], typeof(ConnectionApprovedMessage));

0 commit comments

Comments
 (0)