fix(vet): Add a nil pointer check to prevent db/prepare panic (sqlc-dev#2934)

andrewmbenton · web-flow · commit 273d7c8660fd · 2023-11-01T09:59:24.000-07:00
resolves sqlc-dev#2933
diff --git a/internal/cmd/vet.go b/internal/cmd/vet.go
@@ -334,7 +334,9 @@ type dbPreparer struct {
 
 func (p *dbPreparer) Prepare(ctx context.Context, name, query string) error {
 	s, err := p.db.PrepareContext(ctx, query)
-	s.Close()
+	if s != nil {
+		s.Close()
+	}
 	return err
 }
 

Original file line number	Diff line number	Diff line change
`@@ -334,7 +334,9 @@ type dbPreparer struct {`
`334`	`334`
`335`	`335`	`func (p *dbPreparer) Prepare(ctx context.Context, name, query string) error {`
`336`	`336`	`s, err := p.db.PrepareContext(ctx, query)`
`337`		`- s.Close()`
	`337`	`+ if s != nil {`
	`338`	`+ s.Close()`
	`339`	`+ }`
`338`	`340`	`return err`
`339`	`341`	`}`
`340`	`342`